API Standardise extension hooks

symbiote · Aug 25, 2024 · 24e598a · 24e598a
1 parent 1ef6b77
commit 24e598a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/src/DataObjects/WorkflowInstance.php b/src/DataObjects/WorkflowInstance.php
@@ -669,7 +669,6 @@ public function getWorkflowFields()
         $fields->push(HiddenField::create('TransitionID', ''));
         // Let the Active Action update the fields that the user can interact with so that data can be
         // stored for the workflow.
-        $action->updateWorkflowFields($fields);
         $action->invokeWithExtensions('updateWorkflowFields', $fields);
         return $fields;
     }

diff --git a/src/Extensions/AdvancedWorkflowExtension.php b/src/Extensions/AdvancedWorkflowExtension.php
@@ -62,7 +62,7 @@ public function startworkflow($data, $form, $request)
      *
      * @param Form $form
      */
-    public function updateEditForm(Form $form)
+    protected function updateEditForm(Form $form)
     {
         Requirements::javascript('symbiote/silverstripe-advancedworkflow:client/dist/js/advancedworkflow.js');
         $service = singleton(WorkflowService::class);

diff --git a/src/Extensions/WorkflowEmbargoExpiryExtension.php b/src/Extensions/WorkflowEmbargoExpiryExtension.php
@@ -547,7 +547,7 @@ public function getIsUnPublishScheduled()
      * @param Member $member
      * @return bool|null
      */
-    public function canEdit($member)
+    protected function canEdit($member)
     {
         if (!Permission::check('EDIT_EMBARGOED_WORKFLOW') && // not given global/override permission to edit
             !$this->owner->AllowEmbargoedEditing) { // item flagged as not editable