Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Button layout that display icons #516

Merged

Conversation

satrun77
Copy link

@satrun77 satrun77 commented Jan 25, 2024

Description

The workflow interface looks like the following
Screenshot 2024-01-25 at 12 13 13 PM

Similar issue in silverstripe/silverstripe-admin#1581

Manual testing steps

  • Install workflow
  • Create a new one
  • See the extra icons

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR works as expected.

Since this is a bug fix, you can target the 6.1 branch if you like (you may need to reset your commits afterward), and then this can be released immediately as a patch.
Otherwise if it's merged on the 6 branch it won't be available until the next minor release in April.

Up to you either way - I'm happy to merge as-is if you don't want to retarget the PR.

@satrun77 satrun77 changed the base branch from 6 to 6.1 January 25, 2024 21:25
@satrun77 satrun77 force-pushed the pulls/fixes-button-icons branch from f484336 to 5e3b9b0 Compare January 25, 2024 21:28
@satrun77
Copy link
Author

@GuySartorelli Done thanks

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 08fa6fd into symbiote:6.1 Jan 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants