Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add job error logging #309

Open
wants to merge 2 commits into
base: 4
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,18 @@ Symbiote\QueuedJobs\Services\QueuedJobService\QueuedJobsService:
ALTER TABLE `QueuedJobDescriptor` ADD INDEX ( `JobStatus` , `JobType` )
```

## Job error logging

The logger can be attached to a helper which is executed within a job like below:

```php
$job = new YourQueuedJob($someArguments);
$logger = new Logger();
$logger->setJob($job);
$helper = Helper::create();
$helper->setLogger($logger);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this example should be changed to reflect a more common situation where the logging is attached within the job execution. i.e. within the process() function of the job

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean something like this?

$logger = new Logger();
$logger->setJob($job);

$helper = Helper::create();
$helper->setLogger($logger)
            ->run();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this:

// within your job class

public function process(): void
{
    $logger = new Logger();
    $logger->setJob($this);

    Helper::create()
        ->setLogger($logger)
        ->run();
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Helper isn't defined, I still think this is quite confusing. Regardless, I'm not sure why there's a need to mix in the concept of a "helper class" with the creation of a logger, seems like unnecessary noise? It's pretty clear how a logger can be used (incl. passing it to other hypothetical dependencies) once it's created.

```

## Unit tests

Writing units tests for queued jobs can be tricky as it's quite a complex system. Still, it can be done.
Expand Down
90 changes: 90 additions & 0 deletions src/Util/Logger.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
<?php

namespace Symbiote\QueuedJobs\Util;

use Psr\Log\LoggerInterface;
use Psr\Log\LogLevel;
use Symbiote\QueuedJobs\Services\QueuedJob;

/**
* Class Logger
*
* This logger redirects all log messages to the queued job
* which makes the job data contain all relevant logs
*
* @package Symbiote\QueuedJobs\Util
*/
class Logger implements LoggerInterface
{
/**
* @var QueuedJob|null
*/
private $job = null;

public function setJob(?QueuedJob $job): self
{
$this->job = $job;
return $this;
}

public function getJob(): ?QueuedJob
{
return $this->job;
}

public function debug($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::DEBUG);
}

public function critical($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::CRITICAL);
}

public function alert($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::ALERT);
}

public function emergency($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::EMERGENCY);
}

public function warning($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::WARNING);
}

public function error($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::ERROR);
}

public function notice($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::NOTICE);
}

public function info($message, array $context = []): void
{
$this->logJobMessage($message, LogLevel::INFO);
}

public function log($level, $message, array $context = []): void
{
$this->logJobMessage($message, $level, $context);
}

private function logJobMessage(string $message, string $level, array $context = []): void
{
$job = $this->job;

if (!$job instanceof QueuedJob) {
return;
}

$job->addMessage($message, $level);
}
}
202 changes: 202 additions & 0 deletions tests/Util/LoggerTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,202 @@
<?php

namespace Symbiote\QueuedJobs\Util;

use Psr\Log\LogLevel;
use Symbiote\QueuedJobs\Tests\AbstractTest;
use Symbiote\QueuedJobs\Tests\QueuedJobsTest\TestQJService;
use Symbiote\QueuedJobs\Tests\QueuedJobsTest\TestQueuedJob;

class LoggerTest extends AbstractTest
{
/**
* We need the DB for this test
*
* @var bool
*/
protected $usesDatabase = true;

/**
* @return TestQJService
*/
protected function getService()
{
return singleton(TestQJService::class);
}

private function getLogger()
{
$service = $this->getService();

// Create a job and add it to the queue
$job = new TestQueuedJob();
$service->queueJob($job);

// Create a logger and set it for the created job
$logger = new Logger();
return $logger->setJob($job);
}

/**
* @group logger
*/
public function testSetLogger()
{
$logger = $this->getLogger();
$this->assertNotNull($logger);
}

/**
* @group logger
*/
public function testDebug()
{
$logger = $this->getLogger();

$message = 'This is debug message';
$logger->debug($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::DEBUG), $jobData);
}

/**
* @group logger
*/
public function testCritical()
{
$logger = $this->getLogger();

$message = 'This is critical message';
$logger->critical($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::CRITICAL), $jobData);
}

/**
* @group logger
*/
public function testAlert()
{
$logger = $this->getLogger();

$message = 'This is alert message';
$logger->alert($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::ALERT), $jobData);
}

/**
* @group logger
*/
public function testEmergency()
{
$logger = $this->getLogger();

$message = 'This is emergency message';
$logger->emergency($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::EMERGENCY), $jobData);
}

/**
* @group logger
*/
public function testWarning()
{
$logger = $this->getLogger();

$message = 'This is warning message';
$logger->warning($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::WARNING), $jobData);
}

/**
* @group logger
*/
public function testError()
{
$logger = $this->getLogger();

$message = 'This is error message';
$logger->error($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::ERROR), $jobData);
}

/**
* @group logger
*/
public function testNotice()
{
$logger = $this->getLogger();

$message = 'This is notice message';
$logger->notice($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::NOTICE), $jobData);
}

/**
* @group logger
*/
public function testInfo()
{
$logger = $this->getLogger();

$message = 'This is info message';
$logger->info($message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper(LogLevel::INFO), $jobData);
}

/**
* @dataProvider loggerProvider
* @param $logLevel
* @group logger
*/
public function testLog($logLevel)
{
$logger = $this->getLogger();

$message = 'This is info message';
$logger->log($logLevel, $message);

$jobData = $logger->getJob()->getJobData()->messages[0];
$this->assertContains($message, $jobData);
$this->assertContains(strtoupper($logLevel), $jobData);
}

/**
* @return array
*/
public function loggerProvider()
{
return [
[LogLevel::WARNING],
[LogLevel::EMERGENCY],
[LogLevel::ALERT],
[LogLevel::CRITICAL],
[LogLevel::ERROR],
[LogLevel::NOTICE],
[LogLevel::INFO],
[LogLevel::DEBUG],
];
}
}