Add option to supply configuration using _ss_environment file #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nglasl
suggested changes
Jan 7, 2019
| } | ||
|
|
||
| $config['credentials'] = array( | ||
| 'key' => defined('SS_AWS_KEY') ? SS_AWS_KEY : '', |
There was a problem hiding this comment.
The defined check for these isn't needed if you're already checking the defined above and throwing an exception. Other than that, this looks good to merge!
nglasl
added
affects/v3
effort/easy
and removed
change/minor
impact/medium
type/enhancement
labels
|
@jvdanker I'm keen to hit merge on this since it was only a small change requested, any chance you could please resolve the merge conflict? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows you to supply the AWS credentials using the _ss_environment.yml configuration file. If you don't add the security: section to the configuration, then the SESMailer will try to read the keys from defined constants instead.