[WIP] work on menu bundle upgrade #206
Conversation
| - 5.3 | ||
| - 5.4 | ||
| # - 5.3 | ||
| # - 5.4 |
There was a problem hiding this comment.
i would prefer if you would not change this in your commits - we should see if there happen to be problems with different versions of php / symfony.
its not hard to run the tests locally for fast feedback, just look at the .travis.yml and do the same steps.
| @@ -0,0 +1,3 @@ | |||
| adapter: github | |||
| issue-tracker: github | |||
|
|
|||
There was a problem hiding this comment.
we are not going to use gush...
There was a problem hiding this comment.
try to speak for yourself, in view of such a hostile env i am closing the PRs, maybe i will try later
There was a problem hiding this comment.
I'm sad that you closed this PR because of this one little thing. It contained lots of nice changes.
In fact, there were just 2 problems with this PR (in a PR with 20+ changes):
- Some lost comments, which are quite normal since it's a WIP PR
- You introduced a new tool. When introducing a new tool to a big open source project, you can be sure there will be a discussion with some hard opinions.
There was a problem hiding this comment.
I don’t think there was anything wrong with @wouterj’s comment. He part of the CMF core team and just expressed that he doesn’t want to introduce a new tool to the project. What’s wrong with that?
Sent using Gush