Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document schema changes with DoctrineMigrationsBundle #12

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

cedricziel
Copy link
Contributor

With DoctrineMigrationsBundle, the schema changes will be loaded transparently through a schema listener so that users can apply the schema changes for AclBundle by simply diffing the schema.

@@ -95,6 +95,19 @@ running the following command:
.. code-block:: bash

$ php bin/console acl:init

If you are using `DoctrineMigrationsBundle`, the schema changes can be applied
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing underscore after the link text:

`DoctrineMigrationsBundle`_

If you are using `DoctrineMigrationsBundle`, the schema changes can be applied
by diffing your current schema.

.. code-block:: bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Symfony docs use the terminal code block. I suggest to do the same here.

@cedricziel
Copy link
Contributor Author

@xabbuh I updated the PR. I replaced all bash blocks with terminal ones so it's consistent.

@cedricziel
Copy link
Contributor Author

Anything I could do to make this compliant?

@johnpancoast
Copy link

johnpancoast commented Jun 18, 2018

I'm new to this specific project, but I happened to come across this PR and this part about updating with doctrine migrations which seems like an important thing to clarify.

Looking at the above failed build, it seemed it just timed out on a composer update, but I'm not seeing the details on first glance.

Seems as though we should resolve whatever that issue is, merge this PR, and possibly create a 1.0.1 tag with the updated documentation for future users.

Thoughts?

@OskarStark OskarStark requested a review from xabbuh November 7, 2023 07:44
@OskarStark OskarStark requested a review from derrabus November 7, 2023 08:08
@derrabus
Copy link
Member

derrabus commented Nov 7, 2023

Thank you @cedricziel.

@derrabus derrabus merged commit e626dbc into symfony:main Nov 7, 2023
9 checks passed
@cedricziel cedricziel deleted the cedricziel-patch-1 branch November 8, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants