-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document schema changes with DoctrineMigrationsBundle #12
Conversation
src/Resources/doc/index.rst
Outdated
@@ -95,6 +95,19 @@ running the following command: | |||
.. code-block:: bash | |||
|
|||
$ php bin/console acl:init | |||
|
|||
If you are using `DoctrineMigrationsBundle`, the schema changes can be applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing underscore after the link text:
`DoctrineMigrationsBundle`_
src/Resources/doc/index.rst
Outdated
If you are using `DoctrineMigrationsBundle`, the schema changes can be applied | ||
by diffing your current schema. | ||
|
||
.. code-block:: bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Symfony docs use the terminal
code block. I suggest to do the same here.
@xabbuh I updated the PR. I replaced all bash blocks with terminal ones so it's consistent. |
Anything I could do to make this compliant? |
I'm new to this specific project, but I happened to come across this PR and this part about updating with doctrine migrations which seems like an important thing to clarify. Looking at the above failed build, it seemed it just timed out on a composer update, but I'm not seeing the details on first glance. Seems as though we should resolve whatever that issue is, merge this PR, and possibly create a Thoughts? |
5075518
to
59c93e5
Compare
Thank you @cedricziel. |
With DoctrineMigrationsBundle, the schema changes will be loaded transparently through a schema listener so that users can apply the schema changes for AclBundle by simply diffing the schema.