Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF7 compatibility changes #44

Closed
wants to merge 2 commits into from
Closed

SF7 compatibility changes #44

wants to merge 2 commits into from

Conversation

hgabka
Copy link

@hgabka hgabka commented Jan 12, 2024

Symfony 7 compatibility changes.
symfony/security-acl package still have some incompatibility issues, so a fix is also needed in that package

@hgabka hgabka mentioned this pull request Jan 12, 2024
@xabbuh
Copy link
Member

xabbuh commented Jan 12, 2024

Can you please update the CI config (.github/workflows/ci.yml) to also run a job with Symfony 7 installed?

@hgabka
Copy link
Author

hgabka commented Jan 12, 2024

Added the test on PHP 8.2 and syfony 7

@acrobat
Copy link
Contributor

acrobat commented Mar 29, 2024

Is there anymore work needed here or can I help move this PR forward?

@xabbuh
Copy link
Member

xabbuh commented Mar 29, 2024

The failing tests seem to be related to these changes.

@acrobat
Copy link
Contributor

acrobat commented Mar 29, 2024

@xabbuh I've finished this PR and fixed the failing tests in #45!

@xabbuh
Copy link
Member

xabbuh commented Mar 29, 2024

closing in favour of #45

@xabbuh xabbuh closed this Mar 29, 2024
xabbuh added a commit that referenced this pull request Apr 19, 2024
This PR was merged into the main branch.

Discussion
----------

Allow Symfony 7 and fix incompatibilities

Finished PR #44

Commits
-------

2e5827d Allow Symfony 7 and fix incompatibilities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants