Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataTables] Add DataTables UX integration #2155

Open
wants to merge 10 commits into
base: 2.x
Choose a base branch
from

Conversation

pentiminax
Copy link

Q A
Bug fix? no
New feature? yes
Issues Fix #...
License MIT

I developed an integration of the DataTables library.

I followed the same development pattern as the Chart.js UX integration.

I haven't found how to allow developer to use his own CSS framework because DataTables uses different npm package for each CSS framework : https://datatables.net/download/npm

I dont know if this package can be relevant for Symfony UX.

@carsonbot carsonbot added Feature New Feature Status: Needs Review Needs to be reviewed labels Sep 11, 2024
Copy link
Contributor

@pierredup pierredup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a very quick initial review

src/DataTables/assets/src/controller.ts Outdated Show resolved Hide resolved
src/DataTables/assets/src/controller.ts Outdated Show resolved Hide resolved
src/DataTables/doc/index.rst Outdated Show resolved Hide resolved
src/DataTables/doc/index.rst Outdated Show resolved Hide resolved
src/DataTables/doc/index.rst Show resolved Hide resolved
@smnandre
Copy link
Member

Hello @pentiminax ! Thank you very much for this PR.

We need to discuss it and all the team is not available at the moment, but i'll come back to you as soon as i can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants