Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Use ux_package template for ux-icons page #2337

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

karpilin
Copy link

@karpilin karpilin commented Nov 4, 2024

Q A
Bug fix? no
New feature? no
Issues none
License MIT

This changes /icons page to extend generic ux_packages/package template with the main goal to show composer require symfony/ux-icons in the page package-header section, just like on all other package pages.

before and after side-by-side:
image

@carsonbot carsonbot added the Status: Needs Review Needs to be reviewed label Nov 4, 2024
@karpilin karpilin changed the title Use ux_package template for ux-icons page [Site] Use ux_package template for ux-icons page Nov 4, 2024
@smnandre
Copy link
Member

smnandre commented Nov 5, 2024

Hi @karpilin ! Thank you very much for your PR. We are changing some things (right now) about the header, so we won't merge your PR for now.

You will see later this week the small changes we're making on the package pages. Then it will be easier to discuss yours :)

This page is not that easy, as the vast majority of people visiting are here to look at icons, but i agree for people wanting to install the component it's a bit deceptive right now.

@smnandre smnandre self-assigned this Nov 5, 2024
@karpilin
Copy link
Author

karpilin commented Nov 6, 2024

Thanks for the feedback @smnandre

The only reason for the change was that it is not immediately obvious that a 'ux-icons' composer package has to be installed before icons can be used. I was just unifying it with other live components.

I'll keep an eye on the repo and will adjust my pr once the upcoming package page changes will be merged in.

@smnandre
Copy link
Member

Hi @karpilin ! I'm coming back to you... we have had some very interesting discussion with the team, and the changes will need a few days to be done... i'm going back to you quickly !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review Needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants