[LiveComponent] Fix form elements unsynced on load (need confirm?) #2376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's try to fix symfony#1958
carsonbot
added
Bug
📊 Packages dist files size differenceThanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
|
|||||||||
Kocal
approved these changes
Nov 15, 2024
Comment on lines
+33
to
+36
| const modelFields = [ | ||
| ...Array.from(component.element.querySelectorAll('[data-model]')), | ||
| ...Array.from(component.element.querySelectorAll('form,input,select,textarea')), | ||
| ]; |
There was a problem hiding this comment.
No?
Suggested change
| const modelFields = [ | |
| ...Array.from(component.element.querySelectorAll('[data-model]')), | |
| ...Array.from(component.element.querySelectorAll('form,input,select,textarea')), | |
| ]; | |
| const modelFields = component.element.querySelectorAll('[data-model],form,input,select,textarea') |
carsonbot
added
Status: Reviewed
smnandre
changed the title
|
If people want to help, you can check this change on your project and tell here if everything OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try to fix #1958
Multiple iterations probably needed here