Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for lockfile #3

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Don't wait for lockfile #3

merged 3 commits into from
Oct 23, 2024

Conversation

OwenMPhillips
Copy link

@OwenMPhillips OwenMPhillips commented Oct 23, 2024

https://symless.atlassian.net/browse/S3-2302

To test:
Run python scripts/install_deps.py on Windows.

@nbolton nbolton force-pushed the S3-2302-broken-dev-2 branch from c9dab3b to 4ba8073 Compare October 23, 2024 19:39
Copy link

github-actions bot commented Oct 23, 2024

Test results

See workflow run for test output.

Job name Unit tests Integration tests
macos-14-arm64 ✅ Pass ✅ Pass
linux-ubuntu-22.04-amd64 ✅ Pass ✅ Pass
linux-almalinux-9-amd64 ✅ Pass ✅ Pass
linux-debian-12-amd64 ✅ Pass ✅ Pass
linux-rockylinux-9-amd64 ✅ Pass ✅ Pass
linux-debian-13-amd64 ✅ Pass ✅ Pass
linux-opensuse-amd64 ✅ Pass ✅ Pass
linux-fedora-39-amd64 ✅ Pass ✅ Pass
linux-fedora-40-amd64 ✅ Pass ✅ Pass
linux-ubuntu-24.04-amd64 ✅ Pass ✅ Pass
linux-archlinux-amd64 ✅ Pass ✅ Pass
linux-manjaro-amd64 ✅ Pass ✅ Pass
linux-ubuntu-22.04-amd64 ✅ Pass ✅ Pass
macos-13-x64 ✅ Pass ✅ Pass
linux-almalinux-9-amd64 ✅ Pass ✅ Pass
linux-rockylinux-9-amd64 ✅ Pass ✅ Pass
linux-debian-12-amd64 ✅ Pass ✅ Pass
linux-opensuse-amd64 ✅ Pass ✅ Pass
windows-2022-x64 ✅ Pass ✅ Pass
linux-fedora-40-amd64 ✅ Pass ✅ Pass
linux-debian-13-amd64 ✅ Pass ✅ Pass
linux-ubuntu-24.04-amd64 ✅ Pass ✅ Pass
linux-archlinux-amd64 ✅ Pass ✅ Pass
linux-manjaro-amd64 ✅ Pass ✅ Pass
macos-14-arm64 ✅ Pass ✅ Pass
macos-13-x64 ✅ Pass ✅ Pass
windows-2022-x64 ✅ Pass ✅ Pass

Copy link

Valgrind summary

See workflow run for full valgrind output.

Unit tests

==3747== HEAP SUMMARY:
==3747==     in use at exit: 50,627 bytes in 331 blocks
==3747==   total heap usage: 36,669 allocs, 36,338 frees, 6,114,602 bytes allocated

==3747== LEAK SUMMARY:
==3747==    definitely lost: 334 bytes in 10 blocks
==3747==    indirectly lost: 734 bytes in 13 blocks
==3747==      possibly lost: 0 bytes in 0 blocks
==3747==    still reachable: 47,543 bytes in 287 blocks
==3747==         suppressed: 0 bytes in 0 blocks
==3747== 
==3747== ERROR SUMMARY: 28 errors from 28 contexts (suppressed: 0 from 0)

Integration tests

==3764== HEAP SUMMARY:
==3764==     in use at exit: 42,292 bytes in 323 blocks
==3764==   total heap usage: 3,030 allocs, 2,707 frees, 774,043 bytes allocated

==3764== LEAK SUMMARY:
==3764==    definitely lost: 912 bytes in 39 blocks
==3764==    indirectly lost: 80 bytes in 4 blocks
==3764==      possibly lost: 1,600 bytes in 4 blocks
==3764==    still reachable: 37,684 bytes in 255 blocks
==3764==         suppressed: 0 bytes in 0 blocks
==3764== 
==3764== ERROR SUMMARY: 44 errors from 44 contexts (suppressed: 0 from 0)

@nbolton nbolton merged commit 3283b50 into master-1.16 Oct 23, 2024
22 checks passed
@nbolton nbolton deleted the S3-2302-broken-dev-2 branch October 23, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants