minor refactoring

symt · Oct 7, 2024 · 2f8e1d4 · 2f8e1d4
1 parent 6d4b7ca
commit 2f8e1d4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/dev/meyi/bn/json/Order.java b/src/main/java/dev/meyi/bn/json/Order.java
@@ -111,8 +111,7 @@ public void updateStatus() {
         RenderUtils.chatNotification(this, "MATCHED");
       } else if (OrderStatus.OUTDATED.equals(newOrderStatus)) {
         RenderUtils.chatNotification(this, "OUTDATED");
-        RenderUtils.sendSound();
-
+        RenderUtils.sendSound(); // might be loud if multiple become oudated at the same time
       }
       this.orderStatus = newOrderStatus;
     }

diff --git a/src/main/java/dev/meyi/bn/utilities/RenderUtils.java b/src/main/java/dev/meyi/bn/utilities/RenderUtils.java
@@ -81,8 +81,10 @@ public static int getStringWidth(String string) {
   }
 
   public static void sendSound() {
-    if (!BazaarNotifier.config.sendSound) return;
-    Minecraft.getMinecraft().thePlayer.playSound("mob.horse.donkey.death", 2.0F, 1.0F); // Todo: add option for which sound to play (possibly)
+    if (BazaarNotifier.config.sendSound) {
+      Minecraft.getMinecraft().thePlayer.playSound("mob.horse.donkey.death", 2.0F, 1.0F); 
+      // TODO: add option for which sound to play (possibly)
+    }
   }
   public static void chatNotification(Order order, String notification) {
     if (!BazaarNotifier.config.showChatMessages) {