Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sound for Outdated order #126

Merged
merged 9 commits into from
Oct 7, 2024
Merged

Added sound for Outdated order #126

merged 9 commits into from
Oct 7, 2024

Conversation

UltimateBoi
Copy link

Option is toggleable in /bn OneConfig menu in the general section.
Only plays the sound on outdated orders.

Copy link
Owner

@symt symt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one thing

import dev.meyi.bn.BazaarNotifier;
import dev.meyi.bn.json.resp.BazaarItem;
import dev.meyi.bn.utilities.RenderUtils;
import net.minecraft.client.Minecraft;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this import?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ll see if I can, give me a few mins

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@symt check now, i think it wasnt being used anyway.

@symt symt changed the base branch from master to beta March 25, 2024 20:14
@symt symt merged commit f971428 into symt:beta Oct 7, 2024
1 check passed
symt added a commit that referenced this pull request Oct 7, 2024
* Update Order.java

Added play sound once order has been outdated

* Fixed

* Fix 2

* Update RenderUtils.java

* Removed import net.minecraft.client.Minecraft;

* Update README.md

Spelling error on the link that caused a 404

* minor refactoring

---------

Co-authored-by: symt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants