-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sound for Outdated order #126
Conversation
Added play sound once order has been outdated
Update Order.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the one thing
import dev.meyi.bn.BazaarNotifier; | ||
import dev.meyi.bn.json.resp.BazaarItem; | ||
import dev.meyi.bn.utilities.RenderUtils; | ||
import net.minecraft.client.Minecraft; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this import?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ll see if I can, give me a few mins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@symt check now, i think it wasnt being used anyway.
Spelling error on the link that caused a 404
* Update Order.java Added play sound once order has been outdated * Fixed * Fix 2 * Update RenderUtils.java * Removed import net.minecraft.client.Minecraft; * Update README.md Spelling error on the link that caused a 404 * minor refactoring --------- Co-authored-by: symt <[email protected]>
Option is toggleable in /bn OneConfig menu in the general section.
Only plays the sound on outdated orders.