-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Adding new chains #3517
base: master
Are you sure you want to change the base?
Conversation
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis PR introduces support for two new blockchain metrics, Unichain and Berachain, across various components. The modifications include updates to the test response structure, GraphQL queries and schema, SQL query columns, and chain ID configurations. The changes extend the existing data model without altering the core functionality, ensuring that new fields are available to provide additional statistics in both tests and production queries. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant GraphQLServer
participant Database
Client->>GraphQLServer: GetDailyStatisticsByChain Query
GraphQLServer->>Database: Execute SQL query with new unichain, berachain columns
Database-->>GraphQLServer: Return aggregated data (Total, unichain, berachain, etc.)
GraphQLServer-->>Client: Return JSON response with added fields
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3517 +/- ##
===================================================
- Coverage 19.63579% 10.98860% -8.64719%
===================================================
Files 145 259 +114
Lines 12136 29476 +17340
===================================================
+ Hits 2383 3239 +856
- Misses 9479 25769 +16290
- Partials 274 468 +194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying sanguine-fe with
|
Latest commit: |
0a0e2a9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://618f5750.sanguine-fe.pages.dev |
Branch Preview URL: | https://explorer-new-chains.sanguine-fe.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me
the not enough arguments in call to pricer.NewCoingeckoPriceFetcher
error is just a fix needed to be merged in from master
Adds explorer updates for Berachain and Unichain
Summary by CodeRabbit