Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Adding new chains #3517

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Defi-Moses
Copy link
Collaborator

@Defi-Moses Defi-Moses commented Feb 13, 2025

Adds explorer updates for Berachain and Unichain

Summary by CodeRabbit

  • New Features
    • Expanded blockchain statistics now include data from two new platforms: Unichain and Berachain.
    • Enhanced analytics deliver updated metrics across API responses, query results, and configuration data.

@Defi-Moses Defi-Moses requested a review from trajan0x as a code owner February 13, 2025 18:21
Copy link
Contributor

coderabbitai bot commented Feb 13, 2025

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • WIP
  • DO NOT MERGE

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This PR introduces support for two new blockchain metrics, Unichain and Berachain, across various components. The modifications include updates to the test response structure, GraphQL queries and schema, SQL query columns, and chain ID configurations. The changes extend the existing data model without altering the core functionality, ensuring that new fields are available to provide additional statistics in both tests and production queries.

Changes

File(s) Change Summary
services/explorer/api/server_test.go Added two pointer fields, Unichain and Berachain, to the Response struct in the TestHandleJSONDailyStat function.
services/explorer/graphql/.../queries.graphql
services/explorer/graphql/server/.../types.graphql
Updated the GraphQL query and schema by introducing the fields unichain and berachain to the response object and DateResultByChain type.
services/explorer/graphql/server/.../partials.go
services/explorer/static/chainIDs.yaml
Modified SQL queries to include new columns for unichain and berachain, and added corresponding chain IDs (130 and 80094) in the chainIDs configuration file.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant GraphQLServer
    participant Database

    Client->>GraphQLServer: GetDailyStatisticsByChain Query
    GraphQLServer->>Database: Execute SQL query with new unichain, berachain columns
    Database-->>GraphQLServer: Return aggregated data (Total, unichain, berachain, etc.)
    GraphQLServer-->>Client: Return JSON response with added fields
Loading

Possibly related PRs

  • Chain Pauses Update #3468: Introduces similar fields (unichain and berachain) in the GraphQL response, aligning with the changes in this PR.

Suggested labels

M-synapse-interface, size/s, Sol, Typescript, M-docs

Suggested reviewers

  • trajan0x
  • ChiTimesChi
  • bigboydiamonds
  • abtestingalpha

Poem

I'm a bunny hopping light and free,
New chains added for all to see.
Unichain and Berachain join the dance,
Data flows with each curious prance.
In code and carrots, we celebrate today—
Hop on board for a brighter way! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Defi-Moses Defi-Moses changed the title Adding new chains [DO NOT MERGE] Adding new chains Feb 13, 2025
@github-actions github-actions bot added go Pull requests that update Go code size/xs labels Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.98860%. Comparing base (b299b5b) to head (0a0e2a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                 Coverage Diff                 @@
##              master       #3517         +/-   ##
===================================================
- Coverage   19.63579%   10.98860%   -8.64719%     
===================================================
  Files            145         259        +114     
  Lines          12136       29476      +17340     
===================================================
+ Hits            2383        3239        +856     
- Misses          9479       25769      +16290     
- Partials         274         468        +194     
Flag Coverage Δ
explorer 4.93656% <ø> (?)
promexporter 6.81642% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Feb 13, 2025

Deploying sanguine-fe with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a0e2a9
Status: ✅  Deploy successful!
Preview URL: https://618f5750.sanguine-fe.pages.dev
Branch Preview URL: https://explorer-new-chains.sanguine-fe.pages.dev

View logs

Copy link
Collaborator

@parodime parodime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right to me

the not enough arguments in call to pricer.NewCoingeckoPriceFetcher error is just a fix needed to be merged in from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants