-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add settings and detail page to apps #47
base: master
Are you sure you want to change the base?
Conversation
I think if you center the filters horizontally it will look better. |
Also I am mostly using mobile so you need to make sure it does not break it |
Thanks for feedback. Sounds like you are ok with the feature ideas in general? So I will implement your comments and make bug fixes and get back to you for final approval. |
Yes, it just never made to the top of the priority. |
Also grid switch is a bit odd comparing to the other two controls. |
In general it is difficult to actually create something better and maintainable without using a proper web framework. On device for example (https://github.com/syncloud/platform/tree/master/www) I am using Vue.js v3 with element-plus component library (https://element-plus.org/en-US/component/overview.html) which gives a lot of power. I am not saying it has to be used right now but it would give you an easy access to a set of components, but it can be done later when moving to store web. |
Hi @cyberb , I pushed a new version. I think it looks much better now and I also tested it with a smartphone. It's not perfect and certainly needs improvements but I think it's good enough for a first release. I also added a search function. Can you check it out? I totally agree with you. Maybe we can proceed as follows:
|
I think these days sites try to be simpler and have a single scroll (the main one) by not limiting vertical size of any component, this would have less confusion of what to scroll by placing the mouse or a finger in different areas of the screen. So I would prefer filters at the top of the page which are moved away with the page as you scroll, simple and very practical (in my mind) |
Removed and in one line.
Also in mobile on same line now.
Done. Just one scroll bar now.
Color is now corrected for buttons. |
Hi @cyberb , the details usually take the most time. It should now be pixel accurate. I hope it works. |
ok design is good, but functionality is a bit strange, category and name filter do not play well together. |
@cyberb should work better now |
Features:
Todos:
Screenshots: