Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work on PDF tests #335

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

jonjbar
Copy link

@jonjbar jonjbar commented Jan 24, 2025

This PR introduces the foundational setup for testing the PDF generation process. These tests can be improved to ensure that any future changes to the codebase do not unintentionally break the PDF generation functionality. This test suite could also double as a learning resource for new users.

@synopse
Copy link
Owner

synopse commented Jan 24, 2025

Thanks a lot for the interest!

Perhaps also worth adding the existing pdf tests of mORMot 1.

Also, ensure your code compiles with FPC, and has no warning. Your usage of TBytes/string is somewhat dubious.

@jonjbar
Copy link
Author

jonjbar commented Jan 24, 2025

New version should work with FPC, adds tests from mORMot1 and doesn't have any warning.
Recommendations to remove TBytes/string are welcome.

@synopse
Copy link
Owner

synopse commented Jan 24, 2025

Thanks a lot.
I will merge this and make some minor fixes about TEncoding and TBytes (which is not compatible with older Delphi).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants