-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add G10L20 capabilities #275
Open
lekkerkoken
wants to merge
16
commits into
synthetos:master
Choose a base branch
from
lekkerkoken:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was in earlier versions in accordance with linuxcnc.org specification. In the latest version the smaller than sign switched to greater than, which was the cause of faulty error messages.
Adding G10 to the model, and some cleaning up in the ordering of the different types of commands, set NEXT_ACTION_SET_G10_DATA in place of NEXT_ACTION_SET_COORD_DATA
missed a small letter l
adding G10 to canonical Adding G10 to the model, and some cleaning up in the ordering of the different types of commands, set NEXT_ACTION_SET_G10_DATA in place of NEXT_ACTION_SET_COORD_DATA Update canonical_machine.h missed a small letter l
Changed cm_set_coord_offsets to cm_set_g10_data. Commented out the toolsetting L1 and L11
Is done in G2core as well, makes the code more readable.
Work position is unclear if its about wcs with g92 offsets or not.
c_atof is rejected in utils because of the cpp syntax used. Repaired GCode SetModals And NonModals and Debugging It was anoying to work with the template function c_atof_int aborted Repaired GCode SetModals And NonModals Update util.h With the not working code
Because this code doesn't have a extra gcodeflags_t type, there need to be some changes to the comparison. fp_True and the cm_set_g10_data Update canonical_machine.c
removed flag, changed P_word type
G10L20 added and tested
Zero length happens with comments and really small moves. Not an error in my humble opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.