Fix U,V,W axis operation, most notably homing, probing and moving with proper feed rates. #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…V,W homing freeze
prof7bit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes problems with UWW axis and finally make them work for homing, probing and moving as promised in the wiki. Because none of these axes has ever worked in any meaningful way in any branch ever.
e6a6064 fixes the garbled wrong axis letters in position reports when in text mode.
bcef302 fixes that ugly redundant if/else monster that determines the next axis in the axis homing order, it now works with all 9 axes
510b083 is a small patch originating from the edge-preview branch that fixes problems with feed velocity not being respected for the new axes
The last 3 patches finally allow the U,V,W axes to be homed, 6cede50 was responsible for the dreaded homing freeze bug #482
Please merge these essential changes into the edge branch (and possibly also make sure it is in edge-preview) to make the code finally live up to the bold promises of 9 axes from the wiki.
There are some more patches in the DJuke repository, I did not re-submit them again and included only the UWV-axes fixes (which are not specific to any shield or hardware) in this PR. Nonetheless you should also consider merging most of Djuke's important PRs that have been waiting for a very long time because they are also essential for 6-motor / 9-axes operation with the Arduino Due.
I have also submitted my patches to the DJuke repository and if he chooses to merge them this will result in a fully functional version of g2core to be used with the Arduino-Due and the DJuke board.