Updates stb_image and stb_image_write #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Merged! For reading/writing images, we may better to consider adding wuffs https://github.com/google/wuffs and fpng https://github.com/richgel999/fpng (for PNG only) backend for better security and performance. |
|
Filed an issue(wuffs and fpng) #410 |
|
Thank you Syoyo! I've heard very good things about Wuffs in terms of security and performance. |
|
@neilbickford-nv Nice! > I've heard very good things about Wuffs PR of Wuffs backend support is much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Syoyo!
TinyGLTF currently embeds a copy of stb_image.h v2.21 and stb_image_write.h v1.11 from March 2019. This version of stb_image.h has a couple of security vulnerabilities (see this NIST National Vulnerability Database (NVD) search; CVE-2019-19777 is the earliest one).
This pull request updates stb_image and stb_image_write to the latest
devbranch commit, nothings/stb@9f1776a. This commit is the same asmain(stb_image v2.28), plus the fix for nothings/stb#1456.It also applies changes from two pending merge requests:
nullptrdereference when loading certain PIC files and the requested number of channels is 1, 2, or 3 (RUSTSEC-2023-0021).To make this easier to verify, I've split up the commits so that commit 1 matches the dev branch, the diff for commit 2 matches nothings/stb#1454, and the diff for commit 3 matches nothings/stb#1443.
Thank you!