Forward to current with Syscoin chainges #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains all of the changes made to syscoin/HWI merged with the latest master of bitcoin/HWI. This effectively brings the repo up to date, and applies our custom changes.
Changed occurrences of bitcoin to syscoin. This still needs to be tested.
sidhujag
reviewed
Jan 18, 2022
hwilib/_cli.py
Outdated
| getkeypool_parser.add_argument('--internal', action='store_true', help='Indicates that the keys are change keys') | ||
| kp_type_group = getkeypool_parser.add_mutually_exclusive_group() | ||
| kp_type_group.add_argument("--addr-type", help="The address type (and default derivation path) to produce descriptors for", type=AddressType.argparse, choices=list(AddressType), default=AddressType.WIT) # type: ignore | ||
| kp_type_group.add_argument('--all', action='store_true', help='Generate addresses for all standard address types (default paths: ``m/{44,49,84}h/0h/0h/[0,1]/*)``') |
There was a problem hiding this comment.
for bip32 paths we should be type 57 coin not 0, this should be reflective everywhere in the repo
sidhujag
reviewed
Jan 18, 2022
hwilib/key.py
Outdated
|
|
||
| :param chain: The chain | ||
| """ | ||
| if chain == Chain.MAIN: |
…the file was renamed. Also removed other files that are no longer in the repo
This change was applied to a part of the file that was later removed in the main repo. Mistake in merging. Syncing the files up.
Looking for more instances where the chain id 57 needs to be used.
Descriptor wallets are only in 4.3, but hardware wallets are supported as of 4.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains all of the changes made to syscoin/HWI merged with the latest master of bitcoin/HWI. This effectively brings the repo up to date, and applies our custom changes.
Additional changes have been made to .cirrus.yml, this build still needs to be tested, but I'm creating the PR for review purposes. Updates will be applied for changes needed to make it work.