Skip to content

Commit

Permalink
Remove legacy 'INFO' log messages on Cluster checksums
Browse files Browse the repository at this point in the history
These messages were introduced by #44678343, and got deprecated at the same
time that 'admin-checksum_*' were deprecated (#d61d9892). Their original
motivation is summarized in the following note:

```
LOGGING-NOTE: Log only if the remote checksum has just been updated. Avoids
constant logging when 'global_checksum' are not used to prevent individual
modules fetching.
```

These two messages mistakenly survived this deprecation with the introduction
of table 'mysql_servers_v2'.
  • Loading branch information
JavierJF committed May 18, 2024
1 parent 3ef9c5e commit 88af1f1
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions lib/ProxySQL_Cluster.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -562,13 +562,6 @@ void ProxySQL_Node_Entry::set_checksums(MYSQL_RES *_r) {
checksums_values.mysql_servers.checksum, GloVars.checksums_values.mysql_servers.checksum, checksums_values.mysql_servers.diff_check);
}
if (strcmp(checksums_values.mysql_servers.checksum, GloVars.checksums_values.mysql_servers.checksum) == 0) {
// See LOGGING-NOTE at 'admin_variables' above.
if (checksums_values.mysql_servers.last_changed == now) {
proxy_info(
"Cluster: checksum for mysql_servers from peer %s:%d matches with local checksum %s , we won't sync.\n",
hostname, port, GloVars.checksums_values.mysql_servers.checksum
);
}
checksums_values.mysql_servers.diff_check = 0;
proxy_debug(PROXY_DEBUG_CLUSTER, 5, "Checksum for mysql_servers from peer %s:%d matches with local checksum %s, reset diff_check to 0.\n", hostname, port, GloVars.checksums_values.mysql_servers.checksum);
}
Expand Down Expand Up @@ -609,13 +602,6 @@ void ProxySQL_Node_Entry::set_checksums(MYSQL_RES *_r) {
checksums_values.mysql_servers_v2.checksum, GloVars.checksums_values.mysql_servers_v2.checksum, checksums_values.mysql_servers_v2.diff_check);
}
if (strcmp(checksums_values.mysql_servers_v2.checksum, GloVars.checksums_values.mysql_servers_v2.checksum) == 0) {
// See LOGGING-NOTE at 'admin_variables' above.
if (checksums_values.mysql_servers_v2.last_changed == now) {
proxy_info(
"Cluster: checksum for mysql_servers_v2 from peer %s:%d matches with local checksum %s , we won't sync.\n",
hostname, port, GloVars.checksums_values.mysql_servers_v2.checksum
);
}
checksums_values.mysql_servers_v2.diff_check = 0;
proxy_debug(PROXY_DEBUG_CLUSTER, 5, "Checksum for mysql_servers_v2 from peer %s:%d matches with local checksum %s, reset diff_check to 0.\n", hostname, port, GloVars.checksums_values.mysql_servers.checksum);
}
Expand Down

0 comments on commit 88af1f1

Please sign in to comment.