V2.x 240118 [DONOTMERGE] #4431
Closed
V2.x 240118 [DONOTMERGE] #4431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st commit for refactoring the authentication module
Previous commit (2nd refactoring of process_pkt_handshake_response) didn't compile with clickhouse
This branch has code where SHA1_ functions were still used.
New MySQL variable default_authentication_plugin accepting two possible values: * mysql_native_password * caching_sha2_password
Using `enum proxysql_auth_plugins` to define mysql authentication plugins. Also fixed few bugs introduced in previous commits.
Implementation not completed yet, but functional. It allows connections in which the user password is saved in clear password.
Now mysql_users.password can store the authentication_string as in MySQL's mysql.user table. Note: this commit also changes SALT_LEN_MAX in SHA-crypt code from 16 to 20 because MySQL caching_sha2_password uses 20 bytes salt
Extended account_details_t to also store clear_text_password if client provides it during a full authentication in caching_sha2_password . De facto, this implements the "caching" part of caching_sha2_password .
…type Because of the implementation of caching_sha2_password, values of switching_auth_type are shifted by 1
Also added few FIXME to review part of the code
…ysql into v2.x_sha2pass_draft3
Modified generate_one_byte_pkt() to prefix the data with 1 byte. This is the "equivalent" of what MySQL performs in wrap_plguin_data_into_proper_command() , prefixing the data with a command
Input validation on mysql-server_capabilities assumed that it was 16 bits (for historical reasons). This has now improved and supports up to 32 bits. Notes: - some capabilities are changed at runtime while performing the handshake with the client - even if we support 32 bits capabilities, many of them do not have any real meaning for proxysql (not supported) Closes #2091
New variable mysql_listener_paused added to table stats_mysql_global . The variable is a boolean: - true : listener is paused because PROXYSQL PAUSE was executed - false : listener is not paused The variable is also reported by Prometheus exporter as proxysql_mysql_listener_paused Related to #4391
Variable mysql-default_tx_isolation is unused.
In the output of PROXYSQL INTERNAL SESSION and stats_mysql_processlist.extended_info , MultiplexDisabled was only returning the output of MySQL_Connection::MultiplexDisabled() . If there was a transaction, or an error, multiplexing was disabled but MultiplexDisabled() was still reporting false. Therefore it was necessary to also check server_status flag and last_errno. This commits intruduces MultiplexDisabled_ext , that reports the output of: MySQL_Connection::MultiplexDisabled() || MySQL_Connection::isActiveTransaction() This should make troubleshooting easier. Also, removed any reference to deprecated STATUS_MYSQL_CONNECTION_TRANSACTION . Closes #4241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collection of various PRs, for testing purposes.
In order:
#4258
#4424
#4425
#4427
#4428
#4429
#4430