Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL compression level variable and change default to compression level 3 #4764

Open
wants to merge 8 commits into
base: v3.0
Choose a base branch
from
Open

Add MySQL compression level variable and change default to compression level 3 #4764

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a846447
Added MySQL compression level
yashwantsahu20 Nov 27, 2024
a0db6c3
1. Changed name to protocol_compression_level.
yashwantsahu20 Nov 29, 2024
34ef47c
Added test for compression level variable
yashwantsahu20 Nov 29, 2024
4a17a9a
Changes done:
yashwantsahu20 Dec 10, 2024
af7d474
added more checks
yashwantsahu20 Dec 12, 2024
292eddc
Added time calculations for MySQL
yashwantsahu20 Dec 13, 2024
bab1dbc
Added tests for MySQL with and without compression.
yashwantsahu20 Dec 19, 2024
2f3b2da
Merge branch 'v3.0' into v3.0_compression
yashwantsahu20 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions test/tap/tests/mysql-protocol_compression_level-t.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,20 @@ int main(int argc, char** argv) {
unsigned long time_proxy_compressed = 0;
unsigned long diff = 0;
unsigned long time_mysql_compressed = 0;
unsigned long time_mysql_without_compressed = 0;
std::string compression_level = {""};
int32_t ret = 0;
MYSQL* proxysql = nullptr;
MYSQL* proxysql_compression = nullptr;
MYSQL* proxysql_admin = nullptr;
MYSQL* mysql_compression = nullptr;
MYSQL* mysql = nullptr;
int performance_diff = 0;

if(cl.getEnv())
return exit_status();

plan(8);
plan(7);

// ProxySQL connection without compression
proxysql = initilize_mysql_connection(cl.host, cl.username, cl.password, cl.port, false);
Expand All @@ -100,6 +102,12 @@ int main(int argc, char** argv) {
goto cleanup;
}

// MySQL connection without compression
mysql = initilize_mysql_connection(cl.host, cl.username, cl.password, cl.mysql_port, false);
if (!mysql) {
goto cleanup;
}

// ProxySQL admin connection
proxysql_admin = initilize_mysql_connection(cl.host, cl.admin_username, cl.admin_password, cl.admin_port, false);
if (!proxysql_admin) {
Expand Down Expand Up @@ -144,10 +152,16 @@ int main(int argc, char** argv) {
goto cleanup;
}

diff = time_proxy_compressed - time_mysql_compressed;
performance_diff = (diff * 100) / time_mysql_compressed;
time_mysql_without_compressed = calculate_query_execution_time(mysql, query);
yashwantsahu20 marked this conversation as resolved.
Show resolved Hide resolved
diag("Time taken for query with mysql without compression: %ld", time_mysql_without_compressed);
if (time_mysql_without_compressed == -1) {
goto cleanup;
}

diff = time_mysql_without_compressed - time_mysql_compressed;
performance_diff = (diff * 100) / time_mysql_without_compressed;

ok((performance_diff < 20), "proxysql with compression performed well compared to mysql with compression. Performance difference: %d percentage", performance_diff);
diag("Time difference for mysql, compression and without compression is: %d", performance_diff);

ret = get_variable_value(proxysql_admin, "mysql-protocol_compression_level", compression_level, true);
if (ret == EXIT_SUCCESS) {
Expand Down Expand Up @@ -232,6 +246,8 @@ int main(int argc, char** argv) {
mysql_close(proxysql_compression);
if (mysql_compression)
mysql_close(mysql_compression);
if (mysql)
mysql_close(mysql);
if (proxysql_admin)
mysql_close(proxysql_admin);

Expand Down