-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mb/system76/meer9: Add power_on_after_fail
#246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled and Disabled are both working nicely, but I'm seeing some weirdness with Keep.
After first flashing firmware with Keep set, an AC loss and restore powers the machine back on as expected. Then if I power the machine off manually, then lose and restore AC power, the machine stays off, as expected. But after this point, the machine acts like it's set to Disable. Whether or not the machine is running first, or shut down manually first, yanking power and plugging it back in results in the machine staying off.
As far as options we're displaying in the BIOS selector, I think just being able to switch between Enabled and Disabled seems like it should be sufficient. If that seems reasonable to everyone, I'll approve.
I meant to comment, not request changes. I'll re-review once we've reached a consensus. |
CR E4h:
So it probably needs to write this bit as well. Bit is inverted and set to SIO control (0b10) works correctly. |
c5aa29f
to
0b2a7c0
Compare
Configure SuperIO for BIOS control of power loss behavior and add CMOS option to allow user control. Enum 1 is used instead of 7 as the `Keep` option does not seem to work on meer9. The same setting via SIO control (CRE4) does work, though. Change-Id: I9a215f5b0ab131a93afc1d8e41f608a263284ad0 Signed-off-by: Tim Crawford <[email protected]>
0b2a7c0
to
cb2d820
Compare
enum changed to 1 to disallow broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enable and Disable are both working as expected on meer9. I did not try Keep again.
Configure SuperIO for BIOS control of power loss behavior and add CMOS option to allow user control.
Enum 1 is used instead of 7 as the
Keep
option does not seem to work on meer9. The same setting via SIO control (CRE4
) does work, though.Test
With default value of
Disable
:With value of
Enable
: