Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update battery thresholds article #1268

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Update battery thresholds article #1268

merged 4 commits into from
Feb 3, 2025

Conversation

ahoneybun
Copy link
Member

This PR does the following:

  • Changes the note to a table about the Pangolin models that do not support either option
  • Moves the table to the top about thresholds in general rather than the bottom
  • Notes that they do not support Charging Thresholds as well as FlexiCharge
  • Adds keywords

@ahoneybun ahoneybun requested review from a team January 28, 2025 13:39
@ahoneybun
Copy link
Member Author

How about this?

Screenshot_2025-01-28_08-57-40

leviport
leviport requested changes Jan 28, 2025
View reviewed changes
content/laptop-battery-thresholds.md Outdated Show resolved Hide resolved
content/laptop-battery-thresholds.md Outdated Show resolved Hide resolved
@ahoneybun ahoneybun requested a review from leviport January 28, 2025 17:58
leviport
leviport approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

thomas-zimmerman
thomas-zimmerman approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@thomas-zimmerman thomas-zimmerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-zimmerman thomas-zimmerman merged commit 18fb828 into master Feb 3, 2025
3 checks passed
@thomas-zimmerman thomas-zimmerman deleted the update-battery-thresholds-article branch February 3, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-zimmerman thomas-zimmerman thomas-zimmerman approved these changes

@leviport leviport leviport approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahoneybun @leviport @thomas-zimmerman