add new CPU fan being used #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fan model's right on the product page of the cooler. I'll add it.
Will also add the date that we switched if I can find it. |
jacobgkau
previously requested changes
Jan 31, 2025
There was a problem hiding this comment.
As I communicated in Slack, this change technically doesn't apply to nebula19-1. We had already bumped to -2 or -3 by the time this occurred.
If we were going to update this section, we'd also need to note it on the Repairs page, not just the overview. But it would be better if we could make an updated nebula19 section for the current version.
jacobgkau
dismissed
their stale review
After checking internally, we are still on version 1 for nebula19.
Co-authored-by: Aaron Honeycutt <[email protected]>
jacobgkau
force-pushed
the
update-nebula-19-CPU-cooler
branch
from
ef6ef63 to
857c4f1
Compare
leviport
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the CPU cooler that is being used in recent nebula19 cases as the optional CPU cooler.
I have not found a part number itself for the cooler or for the fans like we have it for the Noctua that was originally used. I added similar to have the have LCD panel options or Wi-Fi options such as in the latest Lemur Pro (lemp13).