Skip to content

Commit

Permalink
Clean up obsolete code in Ruida driver (#217)
Browse files Browse the repository at this point in the history
* Remove properties obsoleted by c2bee3a

These properties were overlooked during the refactoring in said commit.

* Clean up another obsolete property
  • Loading branch information
TheAssassin authored Apr 21, 2024
1 parent 7d20ee0 commit 1de68f3
Showing 1 changed file with 7 additions and 34 deletions.
41 changes: 7 additions & 34 deletions src/main/java/de/thomas_oster/liblasercut/drivers/Ruida.java
Original file line number Diff line number Diff line change
Expand Up @@ -199,45 +199,18 @@ public boolean canEstimateJobDuration()
return false;
}

/**
* 'runway' for laser to get up to speed when rastering (in mm)
*
*/
// Kept to retain compatibility with older configs
@Deprecated
protected transient boolean useBidirectionalRastering = true;
@Deprecated
private transient Double rasterPadding = 0.;

@Override
public double getRasterPadding() {
return 0;
}

/*
* allow padding to move laser head outside of 'bed'
*/
@Deprecated
private transient boolean allowOutsidePadding;

// fixed value of 0 because the x-sweep processing mode adds all necessary padding. See writeJobCode().
@Override
public boolean getRasterPaddingAllowOutsideMachineSpace() {
return false;
}

/**
* When rastering, whether to always cut from left to right, or to cut in both
* directions? (i.e. use the return stroke to raster as well)
*/
@Deprecated
protected transient boolean useBidirectionalRastering = true;

public boolean getUseBidirectionalRastering()
{
// currently only bidirectional rastering is supported (work mode has to be tested for unidirectional rastering)
return true;
}

public void setUseBidirectionalRastering(boolean useBidirectionalRastering)
{
this.useBidirectionalRastering = useBidirectionalRastering;
public double getRasterPadding() {
return 0;
}

private void find_and_write_bounding_box(LaserJob job) throws IOException
Expand Down Expand Up @@ -615,7 +588,7 @@ public void writeJobCode(LaserJob job, ProgressListener pl) throws IOException {
if ((p instanceof RasterPart) || (p instanceof Raster3dPart))
{
engrave = true;
p = convertRasterizableToVectorPart((RasterizableJobPart)p, job, getUseBidirectionalRastering(), true, true);
p = convertRasterizableToVectorPart((RasterizableJobPart)p, job, true, true, true);
}
/* FALLTHRU */
if (p instanceof VectorPart)
Expand Down

0 comments on commit 1de68f3

Please sign in to comment.