fix bug with tab navigation for mobile devices mode #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
You can see the outcome in the preview by navigating with tab key (Mobile devices mode) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a keyboard user, i noticed one little bug, which made the usage a bit inconvenient. Specifically:
Everything seems good, but when i pressed tab to navigate to next controllable element, i noticed a bug:
As you can see, multiple elements appeared in my screen. The behavior is same with other elements also (button, inputs, ...).
Although it might be better to lock the focus for the modal, the simplest way of fixing it was closing the modal and removing overlay, and moving to next controllable element on tab key press: