Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new locale file ua.json #1032

Closed
wants to merge 4 commits into from

Conversation

DispersiaRoleplay
Copy link

This pull request adds a new file containing translations that have been fully translated into Ukrainian. The translation covers various system messages, commands, and error messages used in the game.

The changes are intended to improve the experience for Ukrainian-speaking players and ensure all in-game text is properly localized.

Checklist
I have personally loaded this code into an updated qbcore project and checked all of its functionality. My code fits the style guidelines.
My PR fits the contribution guidelines.

This pull request adds a new file containing translations that have been fully translated into Ukrainian. The translation covers various system messages, commands, and error messages used in the game.

The changes are intended to improve the experience for Ukrainian-speaking players and ensure all in-game text is properly localized.

Checklist
I have personally loaded this code into an updated qbcore project and checked all of its functionality.
My code fits the style guidelines.
My PR fits the contribution guidelines.
@tabarra tabarra changed the base branch from master to develop February 17, 2025 18:10
@tabarra
Copy link
Owner

tabarra commented Feb 17, 2025

Thanks for the PR @DispersiaRoleplay.
Do you mind checking the test errors below?

Checking validity of the locale files based on 'en.json'.
[ua] is not mapped on localeMap.ts or not on locales folder
[ua.json] Errors found in Українська (за замовчуванням) locale:
- $meta.humanizer_language: language not supported
- nui_warning.warned_by: untrimmed string
- file: is not formatted correctly (must end with a newline)

@DispersiaRoleplay
Copy link
Author

Done, sorry for mistakes, and thank you for help!

tabarra added a commit that referenced this pull request Feb 19, 2025
commit f0e8393d6fcd40421b2caf41a5b28a5756b6d4e8
Author: tabarra <[email protected]>
Date:   Wed Feb 19 11:44:51 2025 -0300

    locale: renamed Ukrainian file and added to localesMap

commit 05100b6
Merge: afc0906 7fd50ea
Author: tabarra <[email protected]>
Date:   Wed Feb 19 11:41:12 2025 -0300

    Merge branch 'develop' into master

commit afc0906
Merge: a9d91a0 de488ed
Author: Dispersia Roleplay <[email protected]>
Date:   Tue Feb 18 12:18:58 2025 +0200

    Merge branch 'develop' into master

commit a9d91a0
Author: Dispersia Roleplay <[email protected]>
Date:   Tue Feb 18 12:18:45 2025 +0200

    Add files via upload

commit c5763d6
Author: Dispersia Roleplay <[email protected]>
Date:   Mon Feb 17 15:24:57 2025 +0200

    Added new locale file ua.json

    This pull request adds a new file containing translations that have been fully translated into Ukrainian. The translation covers various system messages, commands, and error messages used in the game.

    The changes are intended to improve the experience for Ukrainian-speaking players and ensure all in-game text is properly localized.

    Checklist
    I have personally loaded this code into an updated qbcore project and checked all of its functionality.
    My code fits the style guidelines.
    My PR fits the contribution guidelines.
@tabarra
Copy link
Owner

tabarra commented Feb 19, 2025

The PR has been merged but since it was a local squash (had to rename from ua to uk) github didn't detect it, so I'll close the PR manually.
Thanks again for the PR.

@tabarra tabarra closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants