This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Adds in "administrative area" for countries #140
Open
hmcelroy
wants to merge
37
commits into
tableau-mkt-archived:master
Choose a base branch
from
hmcelroy:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Counties would exclude islands (ie Isle of Wight), Nations (ie Scotland), Provinces (ie N. Ireland), and metro areas (ie London) Unless this json supports multiple levels of administrative areas, it seems better to just lump all these items together into a catch all that allows for some specificity outside of town and "United Kingdom"
ISO 3166 -2 supports a two levels of sub areas
ISO-3166 supports a sub region area for France
…trativearea for Italy
…ust a region on its own
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the administrative area and options for the following countries:
All admin areas come from the wikipedia documentation for ISO 3166-2 available on wikipedia.
For ex, UK: https://en.wikipedia.org/wiki/ISO_3166-2:GB
Each entry on Wikipedia is documented with the time and link to document for the ISO 3166 standard.
I did not make any of these entries required, just want options available for use with the jquery addressfield plugin so that it works nicely with my pycountry implementation.
@iamEAP