Fixes incorrect "certificate provided is not valid until ..." #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error-the-certificate-provided-is-not-valid-until-when-starting-tabpy issue: certificate not_before and not_after are naive datetimes in UTC, so now variable should use datetime.utcnow().
|
Thanks for the contribution! Before we can merge this, we need @jhilyard to sign the Salesforce Inc. Contributor License Agreement. |
jakeichikawasalesforce
approved these changes
Jun 22, 2023
|
@jhilyard thanks for the PR. I think the last step is to sign the "salesforce-cla" then I can merge that for you. |
|
@jakeichikawasalesforce I signed the salesforce-cla previously - when I click the signing link it now says "You already signed the CLA on 2023-05-03" and won't let me do so again. Sorry the merge checker doesn't seem to agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://kb.tableau.com/articles/issue/error-the-certificate-provided-is-not-valid-until-when-starting-tabpy issue: certificate not_before and not_after are naive datetimes in UTC, so the now variable should use datetime.utcnow() not datetime.now().
Currently anyone who installs TabPy and then creates a self-signed certificate to use HTTPS in a time zone west of Greenwich gets an error that the certificate is not yet valid. I found this frustrating enough to fork and provide this fix, since my certificate still won't be valid for over an hour. You can probably also retire the KB article referenced above once merged.
Thanks for your attention!