Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiet warnings about casts of function types #464

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

jcflack
Copy link
Contributor

@jcflack jcflack commented Sep 7, 2023

It is easy enough to stop casting _PgObject_pureVirtualCalled to incompatible function types, as it makes modern compilers suspicious, and was only done in three places anyway.

It is easy enough to stop casting _PgObject_pureVirtualCalled
to incompatible function types, as it makes modern compilers
suspicious, and was only done in three places anyway.
@jcflack jcflack merged commit 0ad93fe into REL1_6_STABLE Sep 11, 2023
@TasMot
Copy link

TasMot commented Oct 22, 2023 via email

@jcflack
Copy link
Contributor Author

jcflack commented Oct 22, 2023

I don't have a ready answer. There is a promising-looking presentation here:

https://d1.awsstatic.com/events/Summits/reinvent2022/OPN307_NEW-LAUNCH!-Adding-safe-extensions-to-PostgreSQL.pdf

where slide 7 shows a good selection of PLs including PL/Java, but none of the documentation at the GitHub project mentioned on slide 6 mentions it at all. aws/pg_tle#185 asked about PL/Java support, and the answer sounds a little like "sure, use any trusted PL", but the question about doing so on RDS never really got answered.

Some of the murkiness may come down to the slide deck being a generic presentation "look at all the ways you could use our cool pg_tle thing on a PostgreSQL instance you host on your own", but the list of ways you can use it on RDS may be smaller.

I'm not sure the comments in this closed unrelated PL/Java pull request are where your question will get the most attention. Stack Exchange, maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants