Prune doc references to unsupported PG versions #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17b7d7c (PR #450) dropped conditional code for PostgreSQL before 9.5, the oldest version to be supported by PL/Java 1.6.x. References to older PostgreSQL versions in the docs, however, were not pruned then. Remove those now. The docs also mentioned some paths and other details that changed with the new build system in 1.6; bring those up to date. Also, link to the page on pljava.policy from a couple more places that only touched on policy generally. These changes are not strictly about pre-9.5 PostgreSQL versions, but are details that were similarly overlooked in the PL/Java 1.5 to 1.6 transition.
The build system introduced in 1.6 fixed the "Windows might get -Dpljava.libjvmdefault wrong" issue. Also, by no longer trying to capture compiler/linker messages and classify them, it has fixed the "Not all [ERROR]s are errors" issue. In 1.6, both the pljava and pljava-api jars must be present in $SHAREDIR/pljava at runtime. So a package maintainer may choose to include the API jar additionally in a -devel package that places it where users' development tools will expect, but may not omit it from the base package that installs it where the runtime needs it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
17b7d7c (PR #450) dropped conditional code for PostgreSQL before 9.5, the oldest version to be supported by PL/Java 1.6.x. References to older PostgreSQL versions in the docs, however, were not pruned then. Remove those now.
The docs also mentioned some paths and other details that changed with the new build system in 1.6; bring those up to date. Also, link to the page on
pljava.policyfrom a couple more places that only touched on policy generally. These changes are not strictly about pre-9.5 PostgreSQL versions, but are details that were similarly overlooked in the PL/Java 1.5 to 1.6 transition.