Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor payload parsing logic to handle missing "bn" variable #96

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

Freddyminu
Copy link
Collaborator

Decoder Description

Changing verification and adding another unit test

Type of change

  • Adding a new Decoder of Connector
  • Adding a new Decoder of Network
  • Update or fixing an issue in existing Decoder

Decoder Information and Payload to test and review

  • Documentation of the hardware or protocol:
  • Payload of example the test the decoder:

Checklist for Adding a New Decoder

  • Created a new folder under ./decoders/network/ or ./decoders/connector/ with the name of your decoder.
  • Added a network.jsonc or connector.jsonc file that follows the structure defined in ./schema/.
  • Created version folders and added manifest.jsonc files for each version.
  • Followed the folder structure guidelines for manufacturer and sensor/device model.
  • The code has unit test and it's in TypeScript.

Additional Notes

Please add any other information that you think is important.

@FabianoEger FabianoEger merged commit 149e66d into main Nov 19, 2024
12 checks passed
@FabianoEger FabianoEger deleted the fix/connector-khomp-itg-402-v2 branch November 19, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants