Don't just use GCC-specific NTTP feature test #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__cpp_nontype_template_parameter_class is GCC-specific. It won't work in Clang, for example. Also test for __cpp_nontype_template_args, which is in the standard now. Keep the former test as well so that pre-standard GCC versions still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__cpp_nontype_template_parameter_class is GCC-specific. It won't work in
Clang, for example. Also test for __cpp_nontype_template_args, which is
in the standard now. Keep the former test as well so that pre-standard
GCC versions still work.