Skip to content

Commit

Permalink
Revert Origin's Destructible concept to use std::is_destructible.
Browse files Browse the repository at this point in the history
Commit 2aa1056 changed Origin's
definition of the Destructible concept in terms of the validity
or a pseudo destructor expression rather than std::is_destructible.
That change resulted in reference and array of known bound types
failing to model the Destructible concept as required by C++14 via
the resolution of DR 2049 [1].  This regression is tracked at [2].
This change reverts the change made to the Destructible concept in
that commit.

[1]: http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-defects.html#2049
[2]: asutton#5
  • Loading branch information
tahonermann committed Jan 18, 2016
1 parent 8fa593c commit 89c3444
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions origin/core/concepts.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,7 @@ template<typename T>
concept bool
Destructible()
{
// return std::is_destructible<T>::value;
return requires (T* t) { t->~T(); };
return std::is_destructible<T>::value;
}

// Is true if and only if an object of type T can be constructed with
Expand Down

0 comments on commit 89c3444

Please sign in to comment.