Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark some peer dependencies as optional and remove some unnecessary peer dependencies #1093

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Jun 7, 2024

  • removed prosemirror-* from peerDependencies since @tiptap/core depends on @tiptap/pm which in turn depends on all the prosemirror-* packages.
  • marked optional peer dependencies in peerDependenciesMeta
  • Some of the @taiga-ui peer dependencies like @taiga-ui/core, @taiga-ui/kit, @taiga-ui/cdk, @taiga-ui/i18n and @taiga-ui/legacy are missing from peer dependencies but I don't know what version should be used. Unreleased v4?

Closes #1092

Copy link

lumberjack-bot bot commented Jun 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Jun 7, 2024

BundleMon

Unchanged files (4)
Status Path Size Limits
demo/browser/main.(hash).js
363.44KB +10%
demo/browser/polyfills.(hash).js
17.91KB +10%
demo/browser/styles.(hash).css
11.84KB +10%
demo/browser/runtime.(hash).js
4.5KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
707.95KB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.39%. Comparing base (741ceb4) to head (c57a15c).
Report is 376 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
- Coverage   44.38%   39.39%   -4.99%     
==========================================
  Files         100      139      +39     
  Lines        1967     2622     +655     
  Branches      298      452     +154     
==========================================
+ Hits          873     1033     +160     
- Misses       1039     1587     +548     
+ Partials       55        2      -53     
Flag Coverage Δ
editor 39.39% <ø> (?)
tui-editor ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 171e93c into taiga-family:main Jun 7, 2024
12 checks passed
@splincode
Copy link
Member

@hakimio please, add changes to v1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 - @tiptap/extension-* and most prosemirror-* dependencies should be marked as optional
2 participants