Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add proper Appearance support #1414

Merged
merged 1 commit into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/editor/src/components/editor/editor.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<div class="t-toolbar-wrapper">
<tui-toolbar
*ngIf="editorLoaded && !floatingToolbar"
[disabled]="!interactive || readOnly()"
[disabled]="!interactive()"
[tools]="tools"
(fileAttached)="fileAttached.emit($event)"
>
Expand Down Expand Up @@ -66,7 +66,7 @@
<div [class.t-floating]="floatingToolbar">
<tui-toolbar
*ngIf="editorLoaded && floatingToolbar"
[disabled]="!interactive || readOnly()"
[disabled]="!interactive()"
[tools]="tools"
(fileAttached)="fileAttached.emit($event)"
>
Expand Down
6 changes: 0 additions & 6 deletions projects/editor/src/components/editor/editor.component.less
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,11 @@
isolation: isolate;
font: var(--tui-font-text-m);
border-radius: var(--tui-radius-m);
outline: 0.0625rem solid var(--tui-border-normal);
max-block-size: inherit;
min-block-size: 10rem;
box-sizing: border-box;
overflow: auto;

&._has-focus {
outline-color: var(--tui-background-accent-1);
outline-width: 0.125rem;
}

&::after {
content: '';
display: table;
Expand Down
63 changes: 47 additions & 16 deletions projects/editor/src/components/editor/editor.component.ts
Original file line number Diff line number Diff line change
@@ -1,35 +1,46 @@
import {AsyncPipe, NgIf, NgTemplateOutlet} from '@angular/common';
import type {OnDestroy} from '@angular/core';
import {
ChangeDetectionStrategy,
Component,
computed,
DestroyRef,
ElementRef,
EventEmitter,
inject,
Input,
NgZone,
type OnDestroy,
Output,
ViewChild,
} from '@angular/core';
import {takeUntilDestroyed} from '@angular/core/rxjs-interop';
import {takeUntilDestroyed, toSignal} from '@angular/core/rxjs-interop';
import {WA_WINDOW} from '@ng-web-apis/common';
import type {TuiBooleanHandler, TuiValueTransformer} from '@taiga-ui/cdk';
import {
TUI_TRUE_HANDLER,
type TuiBooleanHandler,
tuiInjectElement,
type TuiValueTransformer,
tuiWatch,
} from '@taiga-ui/cdk';
import {
TUI_FALSE_HANDLER,
TuiActiveZone,
tuiAutoFocusOptionsProvider,
TuiControl,
tuiZonefree,
} from '@taiga-ui/cdk';
import type {TuiDropdownDirective} from '@taiga-ui/core';
import {
TUI_ANIMATIONS_DEFAULT_DURATION,
TUI_APPEARANCE_OPTIONS,
TuiAppearance,
tuiAppearanceFocus,
tuiAppearanceMode,
tuiAppearanceState,
TuiDropdown,
type TuiDropdownDirective,
TuiScrollbar,
TuiWithAppearance,
} from '@taiga-ui/core';
import {delay, fromEvent, throttleTime} from 'rxjs';
import {delay, fromEvent, map, merge, throttleTime} from 'rxjs';

import type {AbstractTuiEditor} from '../../abstract/editor-adapter.abstract';
import {TUI_EDITOR_RESIZE_EVENT} from '../../constants/default-events';
Expand Down Expand Up @@ -73,17 +84,23 @@ import {TuiEditorPortalHost} from './portal/editor-portal-host.component';
providers: [
tuiAutoFocusOptionsProvider({delay: TUI_ANIMATIONS_DEFAULT_DURATION}),
TUI_EDITOR_PROVIDERS,
{
provide: TUI_APPEARANCE_OPTIONS,
useValue: {appearance: 'textfield'},
},
],
hostDirectives: [
TuiWithAppearance,
{
directive: TuiAppearance,
inputs: ['tuiAppearance: appearance'],
},
{
directive: TuiActiveZone,
outputs: ['tuiActiveZoneChange'],
},
],
host: {
ngSkipHydration: 'true',
'[class._has-focus]': 'computedFocused',
'(tuiActiveZoneChange)': 'onActiveZone($event)',
'(click)': 'focus($event)',
},
Expand Down Expand Up @@ -147,7 +164,25 @@ export class TuiEditor extends TuiControl<string> implements OnDestroy {
public readonly focusOut = new EventEmitter<void>();

public hasMentionPlugin = false;
public focused = false;
public readonly hovered = toSignal(
merge(
fromEvent(tuiInjectElement(), 'mouseenter').pipe(map(TUI_TRUE_HANDLER)),
fromEvent(tuiInjectElement(), 'mouseleave').pipe(map(TUI_FALSE_HANDLER)),
).pipe(tuiWatch(this.cdr)),
);

public readonly focused = tuiAppearanceFocus(false);
public readonly m = tuiAppearanceMode(this.mode);
public readonly s = tuiAppearanceState(
computed(() => {
if (this.disabled()) {
return 'disabled';
}

return this.hovered() ? 'hover' : null;
}),
);

public readonly editorService = inject(TuiTiptapEditorService);

@Input('readOnly')
Expand All @@ -165,10 +200,6 @@ export class TuiEditor extends TuiControl<string> implements OnDestroy {
);
}

public get computedFocused(): boolean {
return (this.editor?.isFocused || this.focused) ?? false;
}

public get selectionState(): TuiSelectionState {
return tuiGetSelectionState(this.editor);
}
Expand All @@ -194,7 +225,7 @@ export class TuiEditor extends TuiControl<string> implements OnDestroy {
this.firstInitialValue = processed ?? '';
}

if (!this.focused) {
if (!this.focused()) {
this.doc?.getSelection?.()?.removeAllRanges();
}
}
Expand All @@ -204,7 +235,7 @@ export class TuiEditor extends TuiControl<string> implements OnDestroy {
}

protected get dropdownSelectionHandler(): TuiBooleanHandler<Range> {
if (!this.focused || this.readOnly()) {
if (!this.focused() || this.readOnly()) {
return TUI_FALSE_HANDLER;
}

Expand Down Expand Up @@ -240,7 +271,7 @@ export class TuiEditor extends TuiControl<string> implements OnDestroy {
}

protected onActiveZone(focused: boolean): void {
this.focused = focused;
this.focused.set(focused);

if (focused) {
this.focusIn.emit();
Expand Down
3 changes: 3 additions & 0 deletions projects/editor/src/components/toolbar/toolbar.style.less
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@
display: flex;
overflow: auto;
flex-wrap: wrap;
padding: 0;
margin: 0;
border: 0;

&:has(.t-block:not(:empty)) {
padding: 0.25rem 0.75rem;
Expand Down
35 changes: 19 additions & 16 deletions projects/editor/src/components/toolbar/toolbar.template.html
Original file line number Diff line number Diff line change
@@ -1,23 +1,26 @@
<button
type="button"
class="t-prevent-parent-label-behavior"
>
<!-- @note: this is a html huck to avoid autofocus, if the parent element is a label -->
</button>
<ng-container *ngIf="!disabled">
<button
type="button"
class="t-prevent-parent-label-behavior"
>
<!-- @note: this is a html hack to avoid autofocus, if the parent element is a label -->
</button>
<div
[tabIndex]="focusable ? 0 : -1"
(focus)="onTopFocus()"
></div>
<div
[tabIndex]="focusable ? 0 : -1"
(focus)="onBottomFocus()"
></div>
</ng-container>
<ng-container *ngIf="editor?.stateChange$ | async" />
<div
[tabIndex]="focusable ? 0 : -1"
(focus)="onTopFocus()"
></div>
<div
[tabIndex]="focusable ? 0 : -1"
(focus)="onBottomFocus()"
></div>
<!-- TODO: Change to `tuiHintDescribe` when figure tuiDriver order issue -->
<section
<fieldset
*ngIf="texts$ | async as texts"
tuiToolbarNavigationManager
class="t-tools-wrapper"
[disabled]="disabled"
>
<div
*ngIf="enabled(editorTool.Undo)"
Expand Down Expand Up @@ -360,4 +363,4 @@
<div class="t-block">
<ng-content />
</div>
</section>
</fieldset>
Loading