-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix link editor's input auto-focus #1482
Conversation
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
@hakimio please, don't use fork |
@splincode I don't have permissions to push to this repo.
|
@hakimio https://taiga-family.github.io/editor/starter-kit it doesn't work now |
I should have tested it a bit better. The issue here is not the query but the delay. Even with delay set to |
Why previous query behaviour doesn't like for you? tuiAutoFocusOptionsProvider({
delay: TUI_ANIMATIONS_DEFAULT_DURATION,
query: '[contenteditable].ProseMirror',
}),
``` |
Because it breaks link editor's input autofocus (and most likely input autofocus in other editor's extensions). |
part of #1462
Custom
query
config is no longer needed since the default one now includes[contenteditable]
. Also, the custom query breaks link editor's input autofocus.