Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop implicit depend on baseHref behaviour #1564

Merged
merged 1 commit into from
Nov 13, 2024
Merged

refactor: drop implicit depend on baseHref behaviour #1564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,11 @@ jobs:
- uses: taiga-family/ci/actions/setup/[email protected]
- uses: taiga-family/ci/actions/setup/[email protected]
- uses: taiga-family/ci/actions/setup/[email protected]
- run: npx nx prerender editor-demo
- run: npx nx prerender editor-demo -c development
- uses: taiga-family/ci/actions/run/[email protected]
with:
port: ${{ env.NG_SERVER_PORT }}
directory: ${{ env.DIST }}
replaceBaseUrlFrom: /editor/
replaceBaseUrlTo: /

- run: npx nx e2e editor-demo-playwright -- --update-snapshots

Expand All @@ -30,8 +28,6 @@ jobs:
with:
port: ${{ env.NG_SERVER_PORT }}
directory: ${{ env.DIST_NEXT }}
replaceBaseUrlFrom: /editor/
replaceBaseUrlTo: /

- run: npx nx e2e editor-demo-playwright
continue-on-error: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snapshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: taiga-family/ci/actions/setup/[email protected]
- uses: taiga-family/ci/actions/setup/[email protected]

- run: npx nx build editor-demo
- run: npx nx prerender editor-demo -c development
- run: tree ${{ env.DIST }} -P '*.html'

- id: info
Expand Down
12 changes: 7 additions & 5 deletions projects/demo/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,12 @@
"vendorChunk": false,
"buildOptimizer": true
},
"ssr": {
"baseHref": "/"
},
"github": {
"baseHref": "/editor/"
},
"development": {}
"development": {
"baseHref": "/"
}
},
"defaultConfiguration": "production"
},
Expand Down Expand Up @@ -130,7 +129,10 @@
"guessRoutes": false
},
"configurations": {
"production": {}
"production": {},
"development": {
"browserTarget": "editor-demo:build:production,development"
}
},
"defaultConfiguration": "production",
"dependsOn": [
Expand Down
Loading