Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo): add example about how disable default hotkeys #1579

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore(demo): add example about how disable default hotkeys #1579

merged 2 commits into from
Nov 18, 2024

Conversation

splincode
Copy link
Member

Fixes #1523

@splincode splincode requested a review from a team as a code owner November 18, 2024 12:19
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 18, 2024 12:19
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 18, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0d71fe1):

https://taiga-editor--pr1579-splincode-small-exam-sozhmf44.web.app

(expires Tue, 19 Nov 2024 12:35:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c332df40371bee0fa68e2139313c6db411ab5f82

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024 •
edited
Loading

Playwright test results

failed  1 failed
passed  16 passed

Details

stats  17 tests across 7 suites
duration  32.2 seconds
commit  0d71fe1
info  For more information, see our report

Failed tests

chromium › tests/toolbar.spec.ts › Toolbar › skips disabled tools and selects next tool after disabled

@splincode splincode force-pushed the splincode/small-example branch from e94a41d to 9560e34 Compare November 18, 2024 12:32
@github-actions github-actions bot added the ready to merge ready label Nov 18, 2024
@splincode splincode merged commit 4f59c9f into main Nov 18, 2024
12 of 14 checks passed
@splincode splincode deleted the splincode/small-example branch November 18, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdlufy mdlufy mdlufy approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

Assignees

@splincode splincode

Labels
ready to merge ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - hotkeys of disabled tools keep on working
3 participants
@splincode @mdlufy @taiga-family-bot