feat: add parseOptions
#1593
Merged
feat: add parseOptions
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splincode
requested review from
MarsiBarsi,
waterplea,
nsbarsukov,
vladimirpotekhin and
mdlufy
and removed request for
a team
splincode
force-pushed
the
splincode/feat/parse-options
branch
from
a5f6427 to
661eb29
Compare
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Tests are running 🚀Wait for workflow run with tests to finish ☕ |
|
Visit the preview URL for this PR (updated for commit 70a376e): https://taiga-editor--pr1593-splincode-feat-parse-options-demo-u8s0qkas.web.app (expires Thu, 21 Nov 2024 08:35:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c332df40371bee0fa68e2139313c6db411ab5f82 |
Playwright test results
Details
Failed testschromium › tests/toolbar.spec.ts › Toolbar › set table without style inheritance |
nsbarsukov
approved these changes
Nov 20, 2024
splincode
force-pushed
the
splincode/feat/parse-options
branch
from
661eb29 to
223bda7
Compare
splincode
force-pushed
the
splincode/feat/parse-options
branch
from
223bda7 to
70a376e
Compare
nsbarsukov
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1584