Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert some wrongly pinned deps #316

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Feb 12, 2024

"peerDependencies": {
"@angular/core": "17.1.2",
"@angular/platform-browser": "17.1.2"
},

Revert these PRs:

Comment on lines +91 to +94
"@nx/angular": "17.3.1",
"@nx/jest": "17.3.1",
"@nx/node": "17.3.1",
"@nx/workspace": "17.3.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7400fe) 100.00% compared to head (25b36da) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #316   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           80        80           
  Branches        17        17           
=========================================
  Hits            80        80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -48,7 +48,7 @@
}
},
"serve": {
"executor": "@nx/angular:webpack-dev-server",
"executor": "@nx/angular:dev-server",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsbarsukov nsbarsukov marked this pull request as ready for review February 12, 2024 13:01
@splincode splincode merged commit 809e1b1 into main Feb 12, 2024
8 checks passed
@splincode splincode deleted the revert-some-pinned-deps branch February 12, 2024 13:04
@github-actions github-actions bot added the ready to merge ready label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants