refactor(kit): new version of InputNumber has [step] feature (#10073

)
taiga-family · Dec 27, 2024 · 2a86fb0 · 2a86fb0
1 parent 9012cd6
commit 2a86fb0
Show file tree

Hide file tree

Showing 14 changed files with 673 additions and 240 deletions.
diff --git a/projects/cdk/constants/allow-signal-writes.ts b/projects/cdk/constants/allow-signal-writes.ts
@@ -0,0 +1,5 @@
+import type {CreateEffectOptions} from '@angular/core';
+import {VERSION} from '@angular/core';
+
+export const TUI_ALLOW_SIGNAL_WRITES: CreateEffectOptions =
+    parseInt(VERSION.major, 10) >= 19 ? {} : {allowSignalWrites: true};
diff --git a/projects/cdk/constants/index.ts b/projects/cdk/constants/index.ts
@@ -1,3 +1,4 @@
+export * from './allow-signal-writes';
 export * from './empty';
 export * from './handlers';
 export * from './matchers';

diff --git a/projects/cdk/constants/used-icons.ts b/projects/cdk/constants/used-icons.ts
@@ -47,6 +47,7 @@ export const TUI_USED_ICONS = [
     '@tui.minus',
     '@tui.file',
     '@tui.trash',
+    '@tui.plus',
     '@tui.phone',
     '@tui.heart',
     '@tui.heart-filled',
@@ -55,7 +56,6 @@ export const TUI_USED_ICONS = [
     '@tui.rotate-ccw-square',
     '@tui.arrow-left',
     '@tui.arrow-right',
-    '@tui.plus',
     '@tui.minimize',
     '@tui.filter',
     '@tui.layout-grid',

diff --git a/projects/cdk/utils/miscellaneous/directive-binding.ts b/projects/cdk/utils/miscellaneous/directive-binding.ts
@@ -1,11 +1,6 @@
-import type {
-    CreateEffectOptions,
-    InjectOptions,
-    ProviderToken,
-    Signal,
-    WritableSignal,
-} from '@angular/core';
-import {effect, inject, isSignal, signal, VERSION} from '@angular/core';
+import type {InjectOptions, ProviderToken, Signal, WritableSignal} from '@angular/core';
+import {effect, inject, isSignal, signal} from '@angular/core';
+import {TUI_ALLOW_SIGNAL_WRITES} from '@taiga-ui/cdk/constants';
 
 type SignalLikeTypeOf<T> = T extends Signal<infer R> ? R : T;
 
@@ -24,11 +19,6 @@ export function tuiDirectiveBinding<
     const result: any = isSignal(initial) ? initial : signal(initial);
     const directive: any = inject(token, options);
     const output = directive[`${key.toString()}Change`];
-    const angularVersion = parseInt(VERSION.major, 10);
-    const isAngular19 = angularVersion >= 19;
-    const effectOptions: CreateEffectOptions = isAngular19
-        ? {}
-        : {allowSignalWrites: true};
 
     // TODO: Figure out why effects are executed all the time and not just when result changes (check with Angular 18)
     let previous: any;
@@ -49,7 +39,7 @@ export function tuiDirectiveBinding<
         directive.ngOnChanges?.({});
         output?.emit?.(value);
         previous = value;
-    }, effectOptions);
+    }, TUI_ALLOW_SIGNAL_WRITES);
 
     return result;
 }
diff --git a/projects/demo-playwright/playwright.config.ts b/projects/demo-playwright/playwright.config.ts
@@ -46,14 +46,16 @@ export default defineConfig({
                 viewport: DEFAULT_VIEWPORT,
             },
         },
-        {
-            name: 'webkit',
-            use: {
-                ...devices['Desktop Safari'],
-                viewport: DEFAULT_VIEWPORT,
-            },
-        },
-    ],
+        process.env.CI
+            ? {
+                  name: 'webkit',
+                  use: {
+                      ...devices['Desktop Safari'],
+                      viewport: DEFAULT_VIEWPORT,
+                  },
+              }
+            : null,
+    ].filter(<T>(x: T | null): x is T => !!x),
     expect: {
         toHaveScreenshot: {
             animations: 'disabled',