Skip to content

Commit

Permalink
chore: slow operations on deep tests
Browse files Browse the repository at this point in the history
  • Loading branch information
splincode committed Dec 13, 2024
1 parent 9ec1e7b commit 4d980f6
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 7 deletions.
1 change: 0 additions & 1 deletion .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ jobs:
needs: [build-demo]
strategy:
fail-fast: false
max-parallel: 9
matrix:
shard: [
# Safari
Expand Down
4 changes: 0 additions & 4 deletions projects/demo-playwright/tests/deep/deep-select.pw.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ test.describe('Deep / Select', () => {
await expect(select).toBeVisible();

await select.click();
await api.waitTuiIcons();

const options = await api.getOptions();

Expand All @@ -47,14 +46,12 @@ test.describe('Deep / Select', () => {
await api.focusOnBody();
await api.hideNotifications();
await api.waitStableState();
await api.waitTuiIcons();

await expect(api.apiPageExample).toHaveScreenshot(
`deep-${path}-${name}-row—${rowIndex}-select-option-${index}.png`,
);

await select.click();
await api.waitTuiIcons();
}

const cleaner = await api.getCleaner(select);
Expand All @@ -69,7 +66,6 @@ test.describe('Deep / Select', () => {

await api.waitStableState();
await api.focusOnBody();
await api.waitTuiIcons();
}
}),
);
Expand Down
2 changes: 0 additions & 2 deletions projects/demo-playwright/tests/deep/deep-toggle.pw.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ test.describe('Deep / Toggle', () => {
await expect(toggle).toBeVisible();

await toggle.click();
await api.waitTuiIcons();
await api.hideNotifications();
await api.waitStableState();
await page.waitForTimeout(100);
Expand All @@ -41,7 +40,6 @@ test.describe('Deep / Toggle', () => {
);

await toggle.click();
await api.waitTuiIcons();
}
}),
);
Expand Down
1 change: 1 addition & 0 deletions projects/demo-playwright/utils/is-flaky-examples.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const FLAKY_EXAMPLES = new Map<string, number[]>([
[DemoRoute.TabBar, [3]], // Imitating server response (timer(3000))
[DemoRoute.Table, [3, 4]], // Imitating server response (delay(3000)) and virtual scroll
[DemoRoute.Tiles, [0]], // YouTube iframe player
[DemoRoute.AppBar, [0]], // Flaky in safari, need to investigate a problem
]);

export function tuiIsFlakyExample(path: string, exampleIndex: number): boolean {
Expand Down

0 comments on commit 4d980f6

Please sign in to comment.