chore: remove redundant eslint rules (#6235)

taiga-family · Dec 12, 2023 · 57ef26b · 57ef26b
1 parent df24fac
commit 57ef26b
Show file tree

Hide file tree

Showing 11 changed files with 394 additions and 164 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -130,7 +130,7 @@
         "@taiga-ui/browserslist-config": "0.4.0",
         "@taiga-ui/commitlint-config": "0.5.0",
         "@taiga-ui/cspell-config": "0.25.0",
-        "@taiga-ui/eslint-plugin-experience": "0.41.1",
+        "@taiga-ui/eslint-plugin-experience": "0.42.0",
         "@taiga-ui/prettier-config": "0.7.0",
         "@taiga-ui/stylelint-config": "0.12.2",
         "@taiga-ui/tsconfig": "0.11.0",

diff --git a/projects/cdk/coercion/coerce-boolean-property.ts b/projects/cdk/coercion/coerce-boolean-property.ts
@@ -5,7 +5,5 @@
 export function tuiCoerceBooleanProperty(
     value: Record<string, any> | boolean | number | string | null | undefined,
 ): boolean {
-    // If you don't mind "[object Object]" in your strings, then you will not need this rule.
-    // eslint-disable-next-line @typescript-eslint/no-base-to-string
     return value !== null && typeof value !== `undefined` && `${value}` !== `false`;
 }
diff --git a/projects/cdk/schematics/ng-update/v3/index.ts b/projects/cdk/schematics/ng-update/v3/index.ts
@@ -91,7 +91,6 @@ function addTaigaStyles(options: TuiSchema): Rule {
             taigaStyles,
             existingStyles =>
                 !!existingStyles?.some(
-                    // eslint-disable-next-line @taiga-ui/experience/no-typeof
                     style => typeof style === `string` && style.includes(`tinkoff-theme`),
                 ),
             stylesToReplace,

diff --git a/projects/cdk/schematics/utils/get-projects.ts b/projects/cdk/schematics/utils/get-projects.ts
@@ -11,7 +11,6 @@ export function getProjects(
         .map(([_, project]) => project);
 
     const nameFromContext =
-        // eslint-disable-next-line @typescript-eslint/no-base-to-string
         options.project || workspace.extensions.defaultProject?.toString() || ``;
     const projectFromContext = workspace.projects.get(nameFromContext);
 

diff --git a/projects/cdk/schematics/utils/push-to-array-property.ts b/projects/cdk/schematics/utils/push-to-array-property.ts
@@ -37,7 +37,6 @@ export function pushToObjectArrayProperty(
         return;
     }
 
-    // eslint-disable-next-line @taiga-ui/experience/no-typeof
     if (typeof index === `number`) {
         importsInitializer.insertElement(index, initializer);
     } else {

diff --git a/projects/cdk/utils/miscellaneous/is-number.ts b/projects/cdk/utils/miscellaneous/is-number.ts
@@ -1,4 +1,3 @@
 export function tuiIsNumber(value: unknown): value is number {
-    // eslint-disable-next-line @taiga-ui/experience/no-typeof
     return typeof value === `number`;
 }
diff --git a/projects/cdk/utils/miscellaneous/is-object.ts b/projects/cdk/utils/miscellaneous/is-object.ts
@@ -1,6 +1,5 @@
 export function tuiIsObject<T extends Record<string, any>>(
     value: unknown,
 ): value is NonNullable<T> {
-    // eslint-disable-next-line @taiga-ui/experience/no-typeof
     return typeof value === `object` && !!value;
 }
diff --git a/projects/cdk/utils/miscellaneous/is-string.ts b/projects/cdk/utils/miscellaneous/is-string.ts
@@ -1,4 +1,3 @@
 export function tuiIsString(value: unknown): value is string {
-    // eslint-disable-next-line @taiga-ui/experience/no-typeof
     return typeof value === `string`;
 }
diff --git a/projects/demo/webpack.config.ts b/projects/demo/webpack.config.ts
@@ -1,5 +1,4 @@
 import {GLOBAL_DEFS_FOR_TERSER_WITH_AOT} from '@angular/compiler-cli';
-import {tuiIsObject} from '@taiga-ui/cdk';
 import TerserPlugin from 'terser-webpack-plugin';
 import {Configuration, RuleSetRule} from 'webpack';
 import {merge} from 'webpack-merge';
@@ -79,7 +78,8 @@ export function makeWebpackConfig({server}: Options): WebpackConf {
 
     return (ngConfigs: Configuration): Configuration => {
         const ngRules = [...(ngConfigs.module?.rules || [])].map(rule =>
-            tuiIsObject(rule) &&
+            typeof rule === `object` &&
+            !!rule &&
             DO_NOT_MUTATE_RAW_FILE_CONTENTS.some(
                 pattern => rule.test instanceof RegExp && rule.test?.test(pattern),
             )

diff --git a/projects/icons/scripts/process-icons.ts b/projects/icons/scripts/process-icons.ts
@@ -75,7 +75,6 @@ export function tuiProcessIcons(files: string[], interceptor?: ContentIntercepto
         const wrapped = wrapIcon(src, name);
 
         const final =
-            // eslint-disable-next-line @taiga-ui/experience/no-typeof
             typeof wrapped === `string`
                 ? `${wrapped.replace(
                       START,