chore(schematics): drop redundant editor providers (#10053)

taiga-family · Dec 26, 2024 · 8b8d6cb · 8b8d6cb
1 parent c786189
commit 8b8d6cb
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 1 deletion.
diff --git a/projects/cdk/schematics/ng-update/v4/index.ts b/projects/cdk/schematics/ng-update/v4/index.ts
@@ -54,9 +54,9 @@ function main(options: TuiSchema): Rule {
     return (tree: Tree, context: SchematicContext) => {
         const fileSystem = getFileSystem(tree);
 
+        migrateEditor(fileSystem, options);
         replaceFunctions(REPLACE_FUNCTIONS);
         migrateImportProvidersFrom(options);
-        migrateEditor(fileSystem, options);
         replaceEnums(options, ENUMS_TO_REPLACE);
         migrateRoot(fileSystem, options);
         replaceServices(options, SERVICES_TO_REPLACE);

diff --git a/projects/cdk/schematics/ng-update/v4/steps/migrate-providers-from.ts b/projects/cdk/schematics/ng-update/v4/steps/migrate-providers-from.ts
@@ -13,6 +13,8 @@ export function migrateImportProvidersFrom(options: TuiSchema): void {
         ...getNamedImportReferences('TuiPushModule', '@taiga-ui/kit'),
         ...getNamedImportReferences('TuiPdfViewerModule', '@taiga-ui/kit'),
         ...getNamedImportReferences('TuiPreviewModule', '@taiga-ui/addon-preview'),
+        ...getNamedImportReferences('TuiEditor', '@taiga-ui/editor'),
+        ...getNamedImportReferences('TuiEditorSocket', '@taiga-ui/editor'),
     ];
 
     for (const ref of refs) {

diff --git a/projects/cdk/schematics/ng-update/v4/tests/schematic-migrate-tinkoff-editor.spec.ts b/projects/cdk/schematics/ng-update/v4/tests/schematic-migrate-tinkoff-editor.spec.ts
@@ -115,6 +115,31 @@ const PACKAGE_JSON_AFTER = `{
     }
 }`.trim();
 
+const MAIN_BEFORE = `
+import '@ng-web-apis/universal/mocks';
+
+import {bootstrapApplication} from '@angular/platform-browser';
+import {TuiEditorModule} from '@tinkoff/tui-editor';
+import {Test} from './app/app/test.component';
+
+bootstrapApplication(AppComponent, {
+    providers: [importProvidersFrom(TuiEditorModule)]
+}).catch((err: unknown) => console.error(err));
+`;
+
+const MAIN_AFTER = `
+import { TuiEditor, TuiEditorSocket } from "@taiga-ui/editor";
+
+
+
+import {bootstrapApplication} from '@angular/platform-browser';
+import {Test} from './app/app/test.component';
+
+bootstrapApplication(AppComponent, {
+    providers: [importProvidersFrom()]
+}).catch((err: unknown) => console.error(err));
+`.trim();
+
 describe('ng-update', () => {
     let host: UnitTestTree;
     let runner: SchematicTestRunner;
@@ -138,6 +163,7 @@ describe('ng-update', () => {
         );
 
         expect(tree.readContent('package.json').trim()).toEqual(PACKAGE_JSON_AFTER);
+        expect(tree.readContent('test/main.ts').trim()).toEqual(MAIN_AFTER);
         expect(tree.readContent('test/app/test.component.ts').trim()).toEqual(
             COMPONENT_AFTER,
         );
@@ -149,6 +175,7 @@ describe('ng-update', () => {
 });
 
 function createMainFiles(): void {
+    createSourceFile('test/main.ts', MAIN_BEFORE);
     createSourceFile('test/app/test.component.ts', COMPONENT_BEFORE);
     createSourceFile('test/app/test.template.html', '');
     createSourceFile('package.json', PACKAGE_JSON_BEFORE);