fix(legacy): `InputPhone` incorrectly parses paste of the shorten phone number #10063

shiv9604 · 2024-12-25T20:30:29Z

Fixes #9834

Changes Description:-

Consider trimming the number with trimCountryPrefix in tuiCreateCompletePhoneInsertionPreprocessor when the pasted phone number is with country code.

lumberjack-bot · 2024-12-25T20:30:36Z

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

github-actions · 2024-12-25T20:34:55Z

Visit the preview URL for this PR (updated for commit fb5387d):

https://taiga-previews-demo--pr10063-bugfix-9834-tui-phone-par-l5if9322.web.app

_{(expires Fri, 27 Dec 2024 14:44:11 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37}

bundlemon · 2024-12-25T20:39:45Z

BundleMon

Files updated (1)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	306.5KB (+12B 0%)	+10%

Unchanged files (4)

Status	Path	Size	Limits
✅	demo/browser/vendor.(hash).js	260.25KB	+10%
✅	demo/browser/runtime.(hash).js	44.2KB	+10%
✅	demo/browser/styles.(hash).css	20.2KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +12B 0%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.45MB (+12B 0%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

projects/legacy/components/input-phone/utils/complete-phone-insertion-preprocessor.ts

shiv9604 · 2024-12-26T11:19:06Z

Just wanted to confirm ensuring test cases succees with jest before push is enough or we need to ensure e2e as well?

shiv9604 · 2024-12-26T13:37:28Z

@shiv9604 just fix unit test please

Yeah @splincode, Working on the same & will publish the commit asap. Will keep you posted about same.

codecov · 2024-12-26T14:39:23Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.98%. Comparing base (c02be62) to head (fb5387d).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...one/utils/complete-phone-insertion-preprocessor.ts	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10063   +/-   ##
=======================================
  Coverage   65.98%   65.98%           
=======================================
  Files        1224     1224           
  Lines       15979    15979           
  Branches     2324     2298   -26     
=======================================
  Hits        10543    10543           
+ Misses       5266     5193   -73     
- Partials      170      243   +73

Flag	Coverage Δ
summary	`65.98% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-12-26T15:26:13Z

Playwright test results

1995 passed
1 flaky
82 skipped

Details

Open report ↗︎
2078 tests across 70 suites
30 minutes, 59 seconds
fb5387d

Flaky tests

webkit › tests/core/hint/hint.pw.spec.ts › TuiHint › false mode hint with delay

Skipped tests

webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with saved cards
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › expired field should be clickable after reset of prefilled value
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-code"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll after click on link with anchor
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [light mode]
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [dark mode]
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Submenu
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Form control
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Complex
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 320x480
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 720x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1024x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1620x1024
webkit › tests/core/surface/surface.pw.spec.ts › Surface › Layers
webkit › tests/kit/carousel/carousel.pw.spec.ts › Carousel › should show next item after drag
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/input-number/input-number.pw.spec.ts › InputNumber › API › [prefix] & [postfix] props › [prefix]="$" & [postfix]="kg" › textfield does not contain any digit (only suffixes) => clear textfield value on blur
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the beginning of the track changes only nearest (left) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the end of the track changes only nearest (right) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click between two thumbs triggers only nearest thumb
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on right slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on left slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Left decreases by one step (after setting right thumb active via click)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set left thumb more than right thumb (by Arrow Right)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set right thumb less than left thumb (by ArrowLeft)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowUp increases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowDown decreases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the LEFT slider MORE THAN position of the RIGHT slider (by ArrowUp)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the RIGHT slider LESS THAN position of the LEFT slider (by ArrowDown)
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › decrease value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 2 steps
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › no extra margin after the last tab
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show settings in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show hint in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › A12y
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is visible when the input is focused
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for s size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for m size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for l size

shiv9604 self-assigned this Dec 25, 2024

shiv9604 requested a review from a team as a code owner December 25, 2024 20:30

shiv9604 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 25, 2024 20:30

splincode force-pushed the bugfix/9834-tui-phone-parse branch from e1c520d to a3a5c1c Compare December 26, 2024 05:46

vladimirpotekhin approved these changes Dec 26, 2024

View reviewed changes

splincode approved these changes Dec 26, 2024

View reviewed changes

github-actions bot added the ready to merge label Dec 26, 2024

nsbarsukov requested changes Dec 26, 2024

View reviewed changes

projects/legacy/components/input-phone/utils/complete-phone-insertion-preprocessor.ts Outdated Show resolved Hide resolved

nsbarsukov reviewed Dec 26, 2024

View reviewed changes

projects/legacy/components/input-phone/utils/complete-phone-insertion-preprocessor.ts Outdated Show resolved Hide resolved

nsbarsukov removed the ready to merge label Dec 26, 2024

shiv9604 force-pushed the bugfix/9834-tui-phone-parse branch from 417c321 to fb1c963 Compare December 26, 2024 14:37

shiv9604 added 2 commits December 26, 2024 17:42

fix(core): resolve number with country code not processing correctly

b0cedaf

fix(core): resolve pr comment

fb5387d

splincode force-pushed the bugfix/9834-tui-phone-parse branch from fb1c963 to fb5387d Compare December 26, 2024 14:42

splincode requested a review from nsbarsukov December 26, 2024 14:43

nsbarsukov changed the title ~~fix(core): resolve number with country code not processing correctly~~ fix(legacy): InputPhone incorrectly parses paste of the shorten phone number Dec 27, 2024

nsbarsukov approved these changes Dec 27, 2024

View reviewed changes

github-actions bot added the ready to merge label Dec 27, 2024

nsbarsukov merged commit 1df2480 into main Dec 27, 2024
37 checks passed

nsbarsukov deleted the bugfix/9834-tui-phone-parse branch December 27, 2024 09:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(legacy): `InputPhone` incorrectly parses paste of the shorten phone number #10063

fix(legacy): `InputPhone` incorrectly parses paste of the shorten phone number #10063

shiv9604 commented Dec 25, 2024 •

edited

Loading

lumberjack-bot bot commented Dec 25, 2024 •

edited

Loading

github-actions bot commented Dec 25, 2024 •

edited

Loading

bundlemon bot commented Dec 25, 2024 •

edited

Loading

shiv9604 commented Dec 26, 2024 •

edited

Loading

shiv9604 commented Dec 26, 2024

codecov bot commented Dec 26, 2024 •

edited

Loading

github-actions bot commented Dec 26, 2024

fix(legacy): InputPhone incorrectly parses paste of the shorten phone number #10063

fix(legacy): InputPhone incorrectly parses paste of the shorten phone number #10063

Conversation

shiv9604 commented Dec 25, 2024 • edited Loading

lumberjack-bot bot commented Dec 25, 2024 • edited Loading

Pull request was closed ✔️

github-actions bot commented Dec 25, 2024 • edited Loading

bundlemon bot commented Dec 25, 2024 • edited Loading

BundleMon

shiv9604 commented Dec 26, 2024 • edited Loading

shiv9604 commented Dec 26, 2024

codecov bot commented Dec 26, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 26, 2024

Playwright test results

Details

fix(legacy): `InputPhone` incorrectly parses paste of the shorten phone number #10063

fix(legacy): `InputPhone` incorrectly parses paste of the shorten phone number #10063

shiv9604 commented Dec 25, 2024 •

edited

Loading

lumberjack-bot bot commented Dec 25, 2024 •

edited

Loading

github-actions bot commented Dec 25, 2024 •

edited

Loading

bundlemon bot commented Dec 25, 2024 •

edited

Loading

shiv9604 commented Dec 26, 2024 •

edited

Loading

codecov bot commented Dec 26, 2024 •

edited

Loading