Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): TuiTime.shift doesn't shift higher order units #10065

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

reverie3
Copy link
Contributor

Fixes #9817

@reverie3 reverie3 requested a review from a team as a code owner December 26, 2024 08:34
@reverie3 reverie3 requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 26, 2024 08:34
Copy link

lumberjack-bot bot commented Dec 26, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (c786189) to head (43ae4d6).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10065      +/-   ##
==========================================
- Coverage   65.57%   65.56%   -0.02%     
==========================================
  Files        1222     1222              
  Lines       15916    15911       -5     
  Branches     2313     2309       -4     
==========================================
- Hits        10437    10432       -5     
+ Misses       5248     5218      -30     
- Partials      231      261      +30     
Flag Coverage Δ
summary 65.56% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Dec 26, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
306.49KB (-21B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.25KB +10%
demo/browser/runtime.(hash).js
44.09KB +10%
demo/browser/styles.(hash).css
20.2KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -21B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.43MB (-21B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode changed the title fix: TuiTime.shift doesn't shift higher order units fix(cdk): TuiTime.shift doesn't shift higher order units Dec 26, 2024
@splincode splincode added the community contribution This issue was closed by a PR from the community label Dec 26, 2024
@splincode splincode merged commit 5939585 into taiga-family:main Dec 26, 2024
35 of 36 checks passed
@reverie3 reverie3 deleted the issue/9817 branch December 27, 2024 08:34
@reverie3
Copy link
Contributor Author

Does it need to be backported to v3.x?

@splincode
Copy link
Member

@reverie3 sure

@reverie3
Copy link
Contributor Author

#10082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community contribution This issue was closed by a PR from the community
Development

Successfully merging this pull request may close these issues.

🐞 - TuiTime.shift doesn't shift higher order units
3 participants