Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support override tui-svg width and height by css variable #5646

Closed
wants to merge 1 commit into from

Conversation

splincode
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

@lumberjack-bot
Copy link

lumberjack-bot bot commented Oct 16, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

:host {
display: inline-flex;
vertical-align: middle;
flex-shrink: 0;
align-items: center;
justify-content: center;
line-height: 0;
height: @default-size;
width: @default-size;
height: var(--tui-svg-size, 1.5rem);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that's on the host, what's the point of it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but if your icons

<svg height="inherit" width="inherit" />

you can immediately set the overall size for all icons

image

@bundlemon
Copy link

bundlemon bot commented Oct 16, 2023

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
336.16KB (+12B 0%) +10%
Unchanged files (5)
Status Path Size Limits
demo/browser/vendor.(hash).js
201.19KB +10%
demo/browser/runtime.(hash).js
38.04KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/scripts.(hash).js
17.9KB +10%
demo/browser/styles.(hash).css
1.67KB +10%

Total files change +12B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.17MB (+12B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

Visit the preview URL for this PR (updated for commit 91aece6):

https://taiga-ui--pr5646-splincode-feat-svg-e8615562.web.app

(expires Tue, 17 Oct 2023 10:53:34 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #5646 (91aece6) into main (529edcc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5646   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files        1448     1448           
  Lines       15776    15776           
  Branches     2219     2219           
=======================================
  Hits        11419    11419           
  Misses       3995     3995           
  Partials      362      362           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 60.53% <ø> (ø)
addon-mobile 61.14% <ø> (ø)
addon-table 60.63% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.74% <ø> (ø)
core 78.16% <ø> (ø)
kit 70.91% <ø> (ø)
summary 72.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@splincode splincode closed this Oct 18, 2023
@splincode splincode deleted the splincode/feat/svg branch October 18, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants